You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2023/01/23 06:45:00 UTC
[jira] [Commented] (YARN-11416) FS2CS should use CapacitySchedulerConfiguration in FSQueueConverterBuilder
[ https://issues.apache.org/jira/browse/YARN-11416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679691#comment-17679691 ]
ASF GitHub Bot commented on YARN-11416:
---------------------------------------
susheel-gupta opened a new pull request, #5320:
URL: https://github.com/apache/hadoop/pull/5320
…CapacitySchedulerConfiguration object
Change-Id: Ifdab821bee6f0f6db4f8b17208d01cf3901820b7
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g., 'HADOOP-17799. Your PR title ...'.
-->
### Description of PR
### How was this patch tested?
### For code changes:
- [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files?
> FS2CS should use CapacitySchedulerConfiguration in FSQueueConverterBuilder
> ---------------------------------------------------------------------------
>
> Key: YARN-11416
> URL: https://issues.apache.org/jira/browse/YARN-11416
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Benjamin Teke
> Assignee: Susheel Gupta
> Priority: Major
>
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.converter.FSQueueConverter and it's builder stores the variable capacitySchedulerConfig as a simple Configuration object instead of CapacitySchedulerConfiguration. This is misleading, as capacitySchedulerConfig suggests that it is indeed a CapacitySchedulerConfiguration and it loses access to the convenience methods to check for various properties. Because of this every time a property getter is changed FS2CS should be checked if it reimplemented the same, otherwise there might be behaviour differences or even bugs.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org