You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/04/06 00:47:51 UTC

[GitHub] [kafka] mjsax commented on a change in pull request #10482: KAFKA-12499: add transaction timeout verification

mjsax commented on a change in pull request #10482:
URL: https://github.com/apache/kafka/pull/10482#discussion_r607414956



##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsProducer.java
##########
@@ -106,7 +107,7 @@ public StreamsProducer(final StreamsConfig config,
                 producerConfigs.put(ProducerConfig.TRANSACTIONAL_ID_CONFIG, applicationId + "-" + taskId);
 
                 eosBetaProducerConfigs = null;
-
+                verifyTransactionTimeoutCompatibility(producerConfigs, config);

Review comment:
       It might be better to do this check in `StreamsConfig` ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org