You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "claudio4j (via GitHub)" <gi...@apache.org> on 2023/06/05 18:20:53 UTC
[GitHub] [camel-k] claudio4j opened a new pull request, #4456: Use capability dependencies from the catalog
claudio4j opened a new pull request, #4456:
URL: https://github.com/apache/camel-k/pull/4456
<!-- Description -->
This depends on [changes in camel-k-runtime](https://github.com/apache/camel-k-runtime/pull/1040)
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
NONE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on a diff in pull request #4456: Use capability dependencies from the catalog
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on code in PR #4456:
URL: https://github.com/apache/camel-k/pull/4456#discussion_r1219059623
##########
resources/camel-catalog-2.16.0-SNAPSHOT.yaml:
##########
@@ -38,6 +38,14 @@ spec:
- groupId: org.apache.camel.k
artifactId: camel-k-runtime
capabilities:
Review Comment:
I think we better not mix concepts. Capabilities are one specific thing. IMO we should introduce a new concept, `Traits` where we include the logic specifically required for traits. Although at the beginning they will contain the same information (basically a list of dependencies), it's very likely they will evolve differently. I think we're likely going to leverage the same field later on in order to include properties and any other trait specific logic which does not necessarily belong to Capabilities.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] claudio4j commented on a diff in pull request #4456: Use capability dependencies from the catalog
Posted by "claudio4j (via GitHub)" <gi...@apache.org>.
claudio4j commented on code in PR #4456:
URL: https://github.com/apache/camel-k/pull/4456#discussion_r1219741957
##########
resources/camel-catalog-2.16.0-SNAPSHOT.yaml:
##########
@@ -38,6 +38,14 @@ spec:
- groupId: org.apache.camel.k
artifactId: camel-k-runtime
capabilities:
Review Comment:
We can use capabilities in this traits context and once we have a clear view of the traits/capabilities, we can interactively separate them with a clear contract in the api and catalog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on a diff in pull request #4456: Use capability dependencies from the catalog
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on code in PR #4456:
URL: https://github.com/apache/camel-k/pull/4456#discussion_r1219761826
##########
resources/camel-catalog-2.16.0-SNAPSHOT.yaml:
##########
@@ -38,6 +38,14 @@ spec:
- groupId: org.apache.camel.k
artifactId: camel-k-runtime
capabilities:
Review Comment:
> We can use capabilities in this traits context and once we have a clear view of the traits/capabilities, we can interactively separate them with a clear contract in the api and catalog.
No. This is a design choice we need to take now as we don't want to break future compatibility. I think the most conservative approach is to split the concepts as they may evolve differently in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] claudio4j closed pull request #4456: Use capability dependencies from the catalog
Posted by "claudio4j (via GitHub)" <gi...@apache.org>.
claudio4j closed pull request #4456: Use capability dependencies from the catalog
URL: https://github.com/apache/camel-k/pull/4456
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org