You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "SolidWallOfCode (via GitHub)" <gi...@apache.org> on 2023/03/04 22:21:28 UTC
[GitHub] [trafficserver] SolidWallOfCode opened a new pull request, #9495: libswoc: update to 1.4.3
SolidWallOfCode opened a new pull request, #9495:
URL: https://github.com/apache/trafficserver/pull/9495
Update to libswoc 1.4.3. This contains a number of fixes, primarily for `MemSpan`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] SolidWallOfCode merged pull request #9495: libswoc: update to 1.4.4
Posted by "SolidWallOfCode (via GitHub)" <gi...@apache.org>.
SolidWallOfCode merged PR #9495:
URL: https://github.com/apache/trafficserver/pull/9495
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] SolidWallOfCode commented on pull request #9495: libswoc: update to 1.4.4
Posted by "SolidWallOfCode (via GitHub)" <gi...@apache.org>.
SolidWallOfCode commented on PR #9495:
URL: https://github.com/apache/trafficserver/pull/9495#issuecomment-1454943822
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 commented on pull request #9495: libswoc: update to 1.4.4
Posted by "masaori335 (via GitHub)" <gi...@apache.org>.
masaori335 commented on PR #9495:
URL: https://github.com/apache/trafficserver/pull/9495#issuecomment-1457180456
OK, the libswoc is tested well in the upstream repo before we import it. Hmm, it should be fine.
But what's the reason why we don't import the whole repo?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] SolidWallOfCode commented on pull request #9495: libswoc: update to 1.4.4
Posted by "SolidWallOfCode (via GitHub)" <gi...@apache.org>.
SolidWallOfCode commented on PR #9495:
URL: https://github.com/apache/trafficserver/pull/9495#issuecomment-1455395713
What would be the benefit of that? Those are run before a libswoc release, and the results won't change for that release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] SolidWallOfCode commented on pull request #9495: libswoc: update to 1.4.3
Posted by "SolidWallOfCode (via GitHub)" <gi...@apache.org>.
SolidWallOfCode commented on PR #9495:
URL: https://github.com/apache/trafficserver/pull/9495#issuecomment-1454909081
[approve ci ubuntu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] brbzull0 commented on pull request #9495: libswoc: update to 1.4.4
Posted by "brbzull0 (via GitHub)" <gi...@apache.org>.
brbzull0 commented on PR #9495:
URL: https://github.com/apache/trafficserver/pull/9495#issuecomment-1456036635
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 commented on pull request #9495: libswoc: update to 1.4.4
Posted by "masaori335 (via GitHub)" <gi...@apache.org>.
masaori335 commented on PR #9495:
URL: https://github.com/apache/trafficserver/pull/9495#issuecomment-1455314247
I don't have any objection to upgrading libswoc, but I'm wondering why this change doesn't have any change in unit tests.
We don't import any unit tests of libswoc?
https://github.com/SolidWallOfCode/libswoc/tree/1.4.4/unit_tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] brbzull0 commented on pull request #9495: libswoc: update to 1.4.4
Posted by "brbzull0 (via GitHub)" <gi...@apache.org>.
brbzull0 commented on PR #9495:
URL: https://github.com/apache/trafficserver/pull/9495#issuecomment-1456230744
It seems we may need [this](https://github.com/apache/trafficserver/pull/9498) to fix the autest(actually fix the issues causing the fail on the autest)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org