You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@servicemix.apache.org by "Oleg Atamanenko (JIRA)" <ji...@apache.org> on 2008/08/08 10:02:52 UTC

[jira] Created: (SM-1506) ServiceMix message priority patch

ServiceMix message priority patch
---------------------------------

                 Key: SM-1506
                 URL: https://issues.apache.org/activemq/browse/SM-1506
             Project: ServiceMix
          Issue Type: Improvement
          Components: servicemix-core
            Reporter: Oleg Atamanenko
             Fix For: 3.2.3
         Attachments: jmsPriority.patch

This patch adds functionality of setting JMS priority to the messages.

The patch is against 3.2.2 tag, not against trunk.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SM-1506) ServiceMix message priority patch

Posted by "Oleg Atamanenko (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/SM-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=44840#action_44840 ] 

Oleg Atamanenko commented on SM-1506:
-------------------------------------

Ok.

As I understand this patch will be released with ServiceMix 3.3, yes?

> ServiceMix message priority patch
> ---------------------------------
>
>                 Key: SM-1506
>                 URL: https://issues.apache.org/activemq/browse/SM-1506
>             Project: ServiceMix
>          Issue Type: Improvement
>          Components: servicemix-core
>    Affects Versions: 3.2.2
>            Reporter: Oleg Atamanenko
>            Assignee: Lars Heinemann
>             Fix For: 3.3
>
>         Attachments: jmsPriority.patch
>
>
> This patch adds functionality of setting JMS priority to the messages.
> The patch is against 3.2.2 tag, not against trunk.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SM-1506) ServiceMix message priority patch

Posted by "Lars Heinemann (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/SM-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=44842#action_44842 ] 

Lars Heinemann commented on SM-1506:
------------------------------------

correct

> ServiceMix message priority patch
> ---------------------------------
>
>                 Key: SM-1506
>                 URL: https://issues.apache.org/activemq/browse/SM-1506
>             Project: ServiceMix
>          Issue Type: Improvement
>          Components: servicemix-core
>    Affects Versions: 3.2.2
>            Reporter: Oleg Atamanenko
>            Assignee: Lars Heinemann
>             Fix For: 3.3
>
>         Attachments: jmsPriority.patch
>
>
> This patch adds functionality of setting JMS priority to the messages.
> The patch is against 3.2.2 tag, not against trunk.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SM-1506) ServiceMix message priority patch

Posted by "Oleg Atamanenko (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/SM-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=44836#action_44836 ] 

Oleg Atamanenko commented on SM-1506:
-------------------------------------

What should I do to tell that I agree to grant asf license to this patch?

> ServiceMix message priority patch
> ---------------------------------
>
>                 Key: SM-1506
>                 URL: https://issues.apache.org/activemq/browse/SM-1506
>             Project: ServiceMix
>          Issue Type: Improvement
>          Components: servicemix-core
>    Affects Versions: 3.2.2
>            Reporter: Oleg Atamanenko
>            Assignee: Lars Heinemann
>             Fix For: 3.3
>
>         Attachments: jmsPriority.patch
>
>
> This patch adds functionality of setting JMS priority to the messages.
> The patch is against 3.2.2 tag, not against trunk.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SM-1506) ServiceMix message priority patch

Posted by "Oleg Atamanenko (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/SM-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oleg Atamanenko updated SM-1506:
--------------------------------

    Attachment: jmsPriority.patch

I have no trunk avaliable now but I was able to create svn diff for my patch (I commited file from 3.2.2 to my sandbox repo and created diff between modified version and from 3.2.2)

Is it ok?



> ServiceMix message priority patch
> ---------------------------------
>
>                 Key: SM-1506
>                 URL: https://issues.apache.org/activemq/browse/SM-1506
>             Project: ServiceMix
>          Issue Type: Improvement
>          Components: servicemix-core
>    Affects Versions: 3.2.2
>            Reporter: Oleg Atamanenko
>            Assignee: Lars Heinemann
>             Fix For: 3.3
>
>         Attachments: jmsPriority.patch
>
>
> This patch adds functionality of setting JMS priority to the messages.
> The patch is against 3.2.2 tag, not against trunk.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SM-1506) ServiceMix message priority patch

Posted by "Lars Heinemann (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/SM-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=44839#action_44839 ] 

Lars Heinemann commented on SM-1506:
------------------------------------

yes, all fine now.
I do change your patch a bit. The constant for the message priority will be moved to JbiConstants instead.
The patch will be applied on smx3 trunk only.

regards
Lars

> ServiceMix message priority patch
> ---------------------------------
>
>                 Key: SM-1506
>                 URL: https://issues.apache.org/activemq/browse/SM-1506
>             Project: ServiceMix
>          Issue Type: Improvement
>          Components: servicemix-core
>    Affects Versions: 3.2.2
>            Reporter: Oleg Atamanenko
>            Assignee: Lars Heinemann
>             Fix For: 3.3
>
>         Attachments: jmsPriority.patch
>
>
> This patch adds functionality of setting JMS priority to the messages.
> The patch is against 3.2.2 tag, not against trunk.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SM-1506) ServiceMix message priority patch

Posted by "Lars Heinemann (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/SM-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=44843#action_44843 ] 

Lars Heinemann commented on SM-1506:
------------------------------------

SM-259 relates to this issue. But this patch here is only a part of the solution. It solves the problem only for JMS flow but not for JCA or SEDA flows.
So it will stay opened...

> ServiceMix message priority patch
> ---------------------------------
>
>                 Key: SM-1506
>                 URL: https://issues.apache.org/activemq/browse/SM-1506
>             Project: ServiceMix
>          Issue Type: Improvement
>          Components: servicemix-core
>    Affects Versions: 3.2.2
>            Reporter: Oleg Atamanenko
>            Assignee: Lars Heinemann
>             Fix For: 3.3
>
>         Attachments: jmsPriority.patch
>
>
> This patch adds functionality of setting JMS priority to the messages.
> The patch is against 3.2.2 tag, not against trunk.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (SM-1506) ServiceMix message priority patch

Posted by "Gert Vanthienen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/SM-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gert Vanthienen reassigned SM-1506:
-----------------------------------

    Assignee: Lars Heinemann

> ServiceMix message priority patch
> ---------------------------------
>
>                 Key: SM-1506
>                 URL: https://issues.apache.org/activemq/browse/SM-1506
>             Project: ServiceMix
>          Issue Type: Improvement
>          Components: servicemix-core
>    Affects Versions: 3.2.2
>            Reporter: Oleg Atamanenko
>            Assignee: Lars Heinemann
>             Fix For: 3.3
>
>         Attachments: jmsPriority.patch
>
>
> This patch adds functionality of setting JMS priority to the messages.
> The patch is against 3.2.2 tag, not against trunk.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SM-1506) ServiceMix message priority patch

Posted by "Gert Vanthienen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/SM-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gert Vanthienen updated SM-1506:
--------------------------------

             Assignee:     (was: Lars Heinemann)
        Fix Version/s: 3.3
                           (was: 3.2.3)
    Affects Version/s: 3.2.2

We should do this for 3.3 since you can't really consider this a bug fix.

> ServiceMix message priority patch
> ---------------------------------
>
>                 Key: SM-1506
>                 URL: https://issues.apache.org/activemq/browse/SM-1506
>             Project: ServiceMix
>          Issue Type: Improvement
>          Components: servicemix-core
>    Affects Versions: 3.2.2
>            Reporter: Oleg Atamanenko
>             Fix For: 3.3
>
>         Attachments: jmsPriority.patch
>
>
> This patch adds functionality of setting JMS priority to the messages.
> The patch is against 3.2.2 tag, not against trunk.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SM-1506) ServiceMix message priority patch

Posted by "Lars Heinemann (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/SM-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Heinemann resolved SM-1506.
--------------------------------

    Resolution: Fixed

applied to smx3 trunk rev.683918
thanks to Oleg for providing the patch

> ServiceMix message priority patch
> ---------------------------------
>
>                 Key: SM-1506
>                 URL: https://issues.apache.org/activemq/browse/SM-1506
>             Project: ServiceMix
>          Issue Type: Improvement
>          Components: servicemix-core
>    Affects Versions: 3.2.2
>            Reporter: Oleg Atamanenko
>            Assignee: Lars Heinemann
>             Fix For: 3.3
>
>         Attachments: jmsPriority.patch
>
>
> This patch adds functionality of setting JMS priority to the messages.
> The patch is against 3.2.2 tag, not against trunk.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (SM-1506) ServiceMix message priority patch

Posted by "Lars Heinemann (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/SM-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Heinemann reassigned SM-1506:
----------------------------------

    Assignee: Lars Heinemann

> ServiceMix message priority patch
> ---------------------------------
>
>                 Key: SM-1506
>                 URL: https://issues.apache.org/activemq/browse/SM-1506
>             Project: ServiceMix
>          Issue Type: Improvement
>          Components: servicemix-core
>    Affects Versions: 3.2.2
>            Reporter: Oleg Atamanenko
>            Assignee: Lars Heinemann
>             Fix For: 3.3
>
>         Attachments: jmsPriority.patch
>
>
> This patch adds functionality of setting JMS priority to the messages.
> The patch is against 3.2.2 tag, not against trunk.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SM-1506) ServiceMix message priority patch

Posted by "Lars Heinemann (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/SM-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=44837#action_44837 ] 

Lars Heinemann commented on SM-1506:
------------------------------------

When you attach a patch, there is a radio button you have to switch to "Grant License to ASF" or something like this.


> ServiceMix message priority patch
> ---------------------------------
>
>                 Key: SM-1506
>                 URL: https://issues.apache.org/activemq/browse/SM-1506
>             Project: ServiceMix
>          Issue Type: Improvement
>          Components: servicemix-core
>    Affects Versions: 3.2.2
>            Reporter: Oleg Atamanenko
>            Assignee: Lars Heinemann
>             Fix For: 3.3
>
>         Attachments: jmsPriority.patch
>
>
> This patch adds functionality of setting JMS priority to the messages.
> The patch is against 3.2.2 tag, not against trunk.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SM-1506) ServiceMix message priority patch

Posted by "Lars Heinemann (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/SM-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=44834#action_44834 ] 

Lars Heinemann commented on SM-1506:
------------------------------------

Oleg,

1. your diff is somehow corrupted. I can't see any file name or line number correctly
    please rebuild this diff in a correct way

2. you did not grant asf license for this patch so we can't put it in the code base

Regards
Lars


> ServiceMix message priority patch
> ---------------------------------
>
>                 Key: SM-1506
>                 URL: https://issues.apache.org/activemq/browse/SM-1506
>             Project: ServiceMix
>          Issue Type: Improvement
>          Components: servicemix-core
>            Reporter: Oleg Atamanenko
>             Fix For: 3.2.3
>
>         Attachments: jmsPriority.patch
>
>
> This patch adds functionality of setting JMS priority to the messages.
> The patch is against 3.2.2 tag, not against trunk.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SM-1506) ServiceMix message priority patch

Posted by "Oleg Atamanenko (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/SM-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=44841#action_44841 ] 

Oleg Atamanenko commented on SM-1506:
-------------------------------------

By the way, Gert told me, that issue SM-259 relates to this. If it so, that issue can be closed as duplicate.

> ServiceMix message priority patch
> ---------------------------------
>
>                 Key: SM-1506
>                 URL: https://issues.apache.org/activemq/browse/SM-1506
>             Project: ServiceMix
>          Issue Type: Improvement
>          Components: servicemix-core
>    Affects Versions: 3.2.2
>            Reporter: Oleg Atamanenko
>            Assignee: Lars Heinemann
>             Fix For: 3.3
>
>         Attachments: jmsPriority.patch
>
>
> This patch adds functionality of setting JMS priority to the messages.
> The patch is against 3.2.2 tag, not against trunk.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SM-1506) ServiceMix message priority patch

Posted by "Oleg Atamanenko (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/SM-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oleg Atamanenko updated SM-1506:
--------------------------------

    Attachment:     (was: jmsPriority.patch)

> ServiceMix message priority patch
> ---------------------------------
>
>                 Key: SM-1506
>                 URL: https://issues.apache.org/activemq/browse/SM-1506
>             Project: ServiceMix
>          Issue Type: Improvement
>          Components: servicemix-core
>    Affects Versions: 3.2.2
>            Reporter: Oleg Atamanenko
>            Assignee: Lars Heinemann
>             Fix For: 3.3
>
>         Attachments: jmsPriority.patch
>
>
> This patch adds functionality of setting JMS priority to the messages.
> The patch is against 3.2.2 tag, not against trunk.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SM-1506) ServiceMix message priority patch

Posted by "Oleg Atamanenko (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/SM-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=44832#action_44832 ] 

Oleg Atamanenko commented on SM-1506:
-------------------------------------

Forgot to mention, this patch should be applied to AbstractJMSFlow.

> ServiceMix message priority patch
> ---------------------------------
>
>                 Key: SM-1506
>                 URL: https://issues.apache.org/activemq/browse/SM-1506
>             Project: ServiceMix
>          Issue Type: Improvement
>          Components: servicemix-core
>            Reporter: Oleg Atamanenko
>             Fix For: 3.2.3
>
>         Attachments: jmsPriority.patch
>
>
> This patch adds functionality of setting JMS priority to the messages.
> The patch is against 3.2.2 tag, not against trunk.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.