You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/06/15 19:58:15 UTC

[GitHub] [incubator-nuttx-apps] patacongo commented on a change in pull request #778: example/posix_spawn: Ensure argv has filename and NULL terminator

patacongo commented on a change in pull request #778:
URL: https://github.com/apache/incubator-nuttx-apps/pull/778#discussion_r652108625



##########
File path: examples/posix_spawn/spawn_main.c
##########
@@ -117,16 +117,20 @@ static unsigned int g_mmstep;     /* Memory Usage at beginning of test step */
 static const char delimiter[] =
   "**************************************"
   "**************************************";
-static const char g_redirect[] = "redirect";
 static const char g_data[]     = "testdata.txt";
 
 static char fullpath[128];
 
-static char * const g_argv[5] =
+static char * const g_hello_argv[5] =
 {
   "hello", "Argument 1", "Argument 2", "Argument 3", NULL
 };
 
+static char * const g_redirect_argv[5] =

Review comment:
       ```suggestion
   static char * const g_redirect_argv[2] =
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org