Re: [PR] [CALCITE-6337] Distinguish naked measure inside and outside aggregation [calcite]

["barrkel (via GitHub)" <gi...@apache.org>]

barrkel commented on code in PR #3738:
URL: https://github.com/apache/calcite/pull/3738#discussion_r1533777780


##########
core/src/main/java/org/apache/calcite/sql/validate/SqlValidator.java:
##########
@@ -912,15 +912,39 @@ interface Config {
      */
     Config withLenientOperatorLookup(boolean lenient);
 
-    /** Returns whether the validator allows measures to be used without the
-     * AGGREGATE function. Default is true. */
-    @Value.Default default boolean nakedMeasures() {
+    /** Returns whether the validator allows measures to be used without
+     * AGGREGATE function outside an aggregating query. Default is true.
+     */

Review Comment:
   There are 96 `/**` doc comments in this source file, 16 of which don't have `*/` on a separate line at the end, and of those, 10 are single-line doc comments. Only 6 doc comments are multi-line with `*/` at the end of the last line, rather than on a line on its own. I changed the style of this comment when editing to bring it into greater consistency with the majority of the rest of the file.
   
   I didn't do an exahustive analysis, but a quick scan of other source files in this directory shows they generally have doc comments with `*/` at the end on a line of its own.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org