You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Sean Owen (JIRA)" <ji...@apache.org> on 2017/08/03 08:11:00 UTC
[jira] [Updated] (SPARK-21623) Comments of parentStats on
ml/tree/impl/DTStatsAggregator.scala is wrong
[ https://issues.apache.org/jira/browse/SPARK-21623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sean Owen updated SPARK-21623:
------------------------------
Priority: Trivial (was: Minor)
Description:
{code:java}
* Note: this is necessary because stats for the parent node are not available
* on the first iteration of tree learning.
*/
private val parentStats: Array[Double] = new Array[Double](statsSize)
{code}
This comment is not right. Actually, parentStats is not only used for the first iteration. It is used with all the iteration for unordered featrues.
was:
{code:java}
* Note: this is necessary because stats for the parent node are not available
* on the first iteration of tree learning.
*/
private val parentStats: Array[Double] = new Array[Double](statsSize)
{code}
This comment is not right. Actually, parentStats is not only used for the first iteration. It is used with all the iteration for unordered featrues.
OK, though it's not even user-facing doc. Not generally worth a JIRA to fix a couple of words in an internal comment, but go ahead
> Comments of parentStats on ml/tree/impl/DTStatsAggregator.scala is wrong
> ------------------------------------------------------------------------
>
> Key: SPARK-21623
> URL: https://issues.apache.org/jira/browse/SPARK-21623
> Project: Spark
> Issue Type: Improvement
> Components: ML
> Affects Versions: 2.3.0
> Reporter: Peng Meng
> Priority: Trivial
>
> {code:java}
> * Note: this is necessary because stats for the parent node are not available
> * on the first iteration of tree learning.
> */
> private val parentStats: Array[Double] = new Array[Double](statsSize)
> {code}
> This comment is not right. Actually, parentStats is not only used for the first iteration. It is used with all the iteration for unordered featrues.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org