You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by GitBox <gi...@apache.org> on 2023/01/20 15:15:28 UTC
[GitHub] [arrow-adbc] lidavidm opened a new issue, #366: [Discuss] Is the conventional commit format working?
lidavidm opened a new issue, #366:
URL: https://github.com/apache/arrow-adbc/issues/366
I've found that it's easy to typo the 'component' and that it's not clear what to use for the component. (For instance: is a cross-language change `fix(c,python)`?) Maybe we should align with the Arrow project and just use the language as the 'component' (so `c`, `python`, `go`, etc.)? Or, we could improve the validation to check that the 'component' really is a subdirectory of the repo (that way we won't typo `go/adbc/flightsql` when we mean `go/adbc/driver/flightsql`).
It doesn't help that GitHub defaults to the commit message, not the PR title/message, when merging - so we'll fix it in the PR, only to have GitHub merge using the original message. We can ask INFRA to change the setting to merge using the PR title/description, if people agree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm closed issue #366: [Discuss] Is the conventional commit format working?
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm closed issue #366: [Discuss] Is the conventional commit format working?
URL: https://github.com/apache/arrow-adbc/issues/366
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm commented on issue #366: [Discuss] Is the conventional commit format working?
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on issue #366:
URL: https://github.com/apache/arrow-adbc/issues/366#issuecomment-1401948240
I'll send in a request to adjust the merge settings shortly.
To Dewey's point: I think we can keep the format, and I'll see about setting up the CI check to catch typos in the 'component' part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] kou commented on issue #366: [Discuss] Is the conventional commit format working?
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #366:
URL: https://github.com/apache/arrow-adbc/issues/366#issuecomment-1399151048
> We can ask INFRA to change the setting to merge using the PR title/description, if people agree.
I like the setting!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] kou commented on issue #366: [Discuss] Is the conventional commit format working?
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #366:
URL: https://github.com/apache/arrow-adbc/issues/366#issuecomment-1403174122
The default commit message: https://issues.apache.org/jira/browse/INFRA-24133
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] paleolimbot commented on issue #366: [Discuss] Is the conventional commit format working?
Posted by GitBox <gi...@apache.org>.
paleolimbot commented on issue #366:
URL: https://github.com/apache/arrow-adbc/issues/366#issuecomment-1398565056
I rather like reading the conventional commit PR notifications...it's not perfectly consistent but it's *more* consistent than Arrow's "language-only" component. I'd like to adopt whatever you do here in nanoarrow, too, and I found it rather awkward when developing the IPC extension to figure out what the component was (Extension-IPC? IPC? C/IPC C-IPC?). The subdirectory makes a lot of sense (`feat(extension/nanoarrow_ipc): foo`). For R stuff, `feat(r/adbcdrivermanager)` I think is kind of nice (again, not perfect).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm commented on issue #366: [Discuss] Is the conventional commit format working?
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on issue #366:
URL: https://github.com/apache/arrow-adbc/issues/366#issuecomment-1403543438
Ah, thank you for filing that, I forgot to come back to this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm commented on issue #366: [Discuss] Is the conventional commit format working?
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on issue #366:
URL: https://github.com/apache/arrow-adbc/issues/366#issuecomment-1420942073
INFRA made the change and it sounds like we can keep conventional-commits - I'll file a follow up to improve the validation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org