[jira] [Commented] (CAMEL-5376) Mail component does not work as expected (Email Deletion is partially broken et Disconnect does not work well)

["Christian Müller (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CAMEL-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13615101#comment-13615101 ] 

Christian Müller commented on CAMEL-5376:
-----------------------------------------

Alexis, can you attach a patch instead of the new implementation. This makes it much more easier for us to review what you changed (http://camel.apache.org/contributing.html).
And we also have to have a unit test which show the issue which is resolved after applying the patch. Do you also consider to provide an unit test?
This all will speed up applying your proposed change...
                
> Mail component does not work as expected (Email Deletion is partially broken et Disconnect does not work well)
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-5376
>                 URL: https://issues.apache.org/jira/browse/CAMEL-5376
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-mail
>    Affects Versions: 2.9.5, 2.10.3
>         Environment:  - Exchange, but should happen with any mail server, since it is not directly related to (See above)
>  - Apache James Server 3.X
>            Reporter: Alexis Kinsella
>            Priority: Minor
>             Fix For: Future
>
>         Attachments: MailConsumer.java
>
>
> The way disconnect is implemented causes issues with some other options of the consumer. For instance "disconnect" option is not compatible with "delete" option.
> The delete action is done in completion action (processCommit: line 185). On line 305, processCommit method checks if folder is open, but "disconnect" option force folder at null value at the end of poll method (Line 149).
> I guess disconnect method should be called on completion after any other completion actions occured: It is not possible to make completion actions if connection to mail server is closed.
> The result of the usage of disconnect option and delete option is a NullPointerException on test: "if (!folder.isOpen())" statement on line 308.
> Issue should be always reproductible.
> I let you fix the priority of the issue, but it is an annoying issue even if there is a workaround by disabling disconnect option ...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira