You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "Usiel (via GitHub)" <gi...@apache.org> on 2023/01/25 08:49:12 UTC
[GitHub] [superset] Usiel opened a new pull request, #22849: chore(config): remove/update unused webserver config
Usiel opened a new pull request, #22849:
URL: https://github.com/apache/superset/pull/22849
### SUMMARY
We stopped using `SUPERSET_WEBSERVER_PROTOCOL`, `SUPERSET_WEBSERVER_ADDRESS`, `SUPERSET_WEBSERVER_PORT` with https://github.com/apache/superset/pull/21076. Removing the config from the base config as there does not seem to be any immediate need for it: We already have `WEBDRIVER_BASEURL` (and the `_USER_FRIENDLY` variant), which are in use all over the project.
Somewhat related to this: Values for `WEBDRIVER_BASEURL` must end with a slash (our default values in code do). Our mdx files sometimes show example values without a trailing slash, which is quite confusing.
Not sure if this requires an extra change in the changelog?
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(cache): remove unused webserver config & handle trailing slashes [superset]
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on PR #22849:
URL: https://github.com/apache/superset/pull/22849#issuecomment-1919442202
Yes please @Usiel ! If you rebase I will do my best to ping the right committer to review and merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Usiel commented on pull request #22849: fix(cache): removeunused webserver config & handle trailing slashes
Posted by "Usiel (via GitHub)" <gi...@apache.org>.
Usiel commented on PR #22849:
URL: https://github.com/apache/superset/pull/22849#issuecomment-1525879656
> Bumping this since I see someone is getting confused by the out-of-date docs that this would have fixed: #22849 Maybe merge this to fix the docs, then address the suggestion from @Antonio-RiveroMartnez about fixing trailing URLs in a different PR?
My apologies, I kinda forgot to push my changes and post a comment :)
I would tend to go with the simple doc fix in this PR only (as suggested), meaning we would only merge the first commit [4eaca42](https://github.com/apache/superset/pull/22849/commits/4eaca423fd2e8c5f39b79c3a0cd92e5d80da961d).
I still pushed the fix for trailing slashes ([0bfe0d7](https://github.com/apache/superset/pull/22849/commits/0bfe0d7a10c47299f42d9ed95a05134a087547aa)) in case we just want to merge it immediately, but I'm also happy to extract that change and work on it on a separate PR; we do not have any tests for the `tasks.cache` module at the moment - could be a good time to get started on that, but it will require more time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Usiel commented on pull request #22849: fix(cache): removeunused webserver config & handle trailing slashes
Posted by "Usiel (via GitHub)" <gi...@apache.org>.
Usiel commented on PR #22849:
URL: https://github.com/apache/superset/pull/22849#issuecomment-1541370688
Rebase on latest `master` - also, another run on the tests, as there were some failures (unrelated imo).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] sfirke commented on pull request #22849: chore(config): remove/update unused webserver config
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on PR #22849:
URL: https://github.com/apache/superset/pull/22849#issuecomment-1513248065
I searched the codebase for the arguments removed by this PR and agree, they are not in use and you got all mentions of them. I can't approve PRs but would approve this one π
Re:
> However, your cache warmup might be broken, because [cache.py#L43](https://github.com/apache/superset/blob/2.1.0/superset/tasks/cache.py#L43) does not handle the base URL ending with a slash. I'm happy to improve this, but not sure if you all would prefer a separate PR for that.
Indeed I've never gotten cache warmup to work π I did not dig into the sub-functions but I see what you're saying, that there's processing done by that library that's not present in cache.py. I think that would be a nice improvement to add it to cache.py#43 to bring it into parity with urls.py, and a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #22849: chore(config): remove/update unused webserver config
Posted by codecov.
codecov[bot] commented on PR #22849:
URL: https://github.com/apache/superset/pull/22849#issuecomment-1403279596
# [Codecov](https://codecov.io/gh/apache/superset/pull/22849?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22849](https://codecov.io/gh/apache/superset/pull/22849?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8e9b566) into [master](https://codecov.io/gh/apache/superset/commit/6f0fed77cfe737122cec98374dc6774240cd6396?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6f0fed7) will **decrease** coverage by `11.44%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #22849 +/- ##
===========================================
- Coverage 67.26% 55.82% -11.44%
===========================================
Files 1877 1877
Lines 72024 72021 -3
Branches 7897 7897
===========================================
- Hits 48445 40205 -8240
- Misses 21551 29788 +8237
Partials 2028 2028
```
| Flag | Coverage Ξ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `52.49% <0.00%> (-0.01%)` | :arrow_down: |
| python | `57.95% <0.00%> (-23.89%)` | :arrow_down: |
| unit | `51.59% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/22849?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/22849?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.09% <0.00%> (-0.67%)` | :arrow_down: |
| [superset/utils/dashboard\_import\_export.py](https://codecov.io/gh/apache/superset/pull/22849?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2ltcG9ydF9leHBvcnQucHk=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset/tags/core.py](https://codecov.io/gh/apache/superset/pull/22849?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFncy9jb3JlLnB5) | `4.54% <0.00%> (-95.46%)` | :arrow_down: |
| [superset/key\_value/commands/update.py](https://codecov.io/gh/apache/superset/pull/22849?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQva2V5X3ZhbHVlL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `0.00% <0.00%> (-90.91%)` | :arrow_down: |
| [superset/key\_value/commands/delete.py](https://codecov.io/gh/apache/superset/pull/22849?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQva2V5X3ZhbHVlL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `0.00% <0.00%> (-87.88%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/22849?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.19%)` | :arrow_down: |
| [superset/key\_value/commands/delete\_expired.py](https://codecov.io/gh/apache/superset/pull/22849?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQva2V5X3ZhbHVlL2NvbW1hbmRzL2RlbGV0ZV9leHBpcmVkLnB5) | `0.00% <0.00%> (-84.00%)` | :arrow_down: |
| [superset/dashboards/commands/importers/v0.py](https://codecov.io/gh/apache/superset/pull/22849?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjAucHk=) | `15.62% <0.00%> (-76.25%)` | :arrow_down: |
| [superset/datasets/commands/create.py](https://codecov.io/gh/apache/superset/pull/22849?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvY3JlYXRlLnB5) | `30.61% <0.00%> (-69.39%)` | :arrow_down: |
| [superset/datasets/commands/update.py](https://codecov.io/gh/apache/superset/pull/22849?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvdXBkYXRlLnB5) | `25.00% <0.00%> (-69.05%)` | :arrow_down: |
| ... and [293 more](https://codecov.io/gh/apache/superset/pull/22849?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: Weβre building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(cache): remove unused webserver config & handle trailing slashes [superset]
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on PR #22849:
URL: https://github.com/apache/superset/pull/22849#issuecomment-1830382928
> cc @eschutho and @michael-s-molina as these unused config variables were never previously referenced in `UPDATING.md` as being deprecated and/or obsolete.
@john-bodley is there an action you think should be taken to remedy this? We could retroactively add to the 2.0.0 release notes in `UPDATING.md` - that's all I can think of, given that the config variables are long gone.
This PR looks good to me but I don't know enough to approve the tests. @Antonio-RiveroMartnez could you take a look now that @Usiel has made the change you requested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Usiel commented on pull request #22849: chore(config): remove/update unused webserver config
Posted by "Usiel (via GitHub)" <gi...@apache.org>.
Usiel commented on PR #22849:
URL: https://github.com/apache/superset/pull/22849#issuecomment-1511786769
> Does WEBDRIVER_BASEURL need to end in a slash? Mine does not in my config and reports etc. all work correctly, I have `WEBDRIVER_BASEURL="http://superset_app:8088"`
Thanks for checking. You are right, reports are fine, as the function that is called ultimately uses a library that is clever enough to handle both cases (ending in a slash or not), see [urls.py#L32](https://github.com/apache/superset/blob/2.1.0/superset/utils/urls.py#L32).
However, your cache warmup might be broken, because [cache.py#L43](
https://github.com/apache/superset/blob/2.1.0/superset/tasks/cache.py#L43) does not handle the base URL ending with a slash. I'm happy to improve this, but not sure if you all would prefer a separate PR for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(cache): remove unused webserver config & handle trailing slashes [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina merged PR #22849:
URL: https://github.com/apache/superset/pull/22849
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(cache): removeunused webserver config & handle trailing slashes [superset]
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on PR #22849:
URL: https://github.com/apache/superset/pull/22849#issuecomment-1814884945
Well I just got burned by the trailing URL thing π© On the plus side, I'm now a committer so could approve this PR. @Usiel do you have interest in picking it up? It would probably need a rebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(cache): remove unused webserver config & handle trailing slashes [superset]
Posted by "Usiel (via GitHub)" <gi...@apache.org>.
Usiel commented on PR #22849:
URL: https://github.com/apache/superset/pull/22849#issuecomment-1827327130
I rebased on the latest `master`. The issue still persists even though there was some refactoring. I fixed the `fetch_url` task to use the existing util function `get_url_path`, which handles trailing slashes.
Ready for another review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] sfirke commented on pull request #22849: chore(config): remove/update unused webserver config
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on PR #22849:
URL: https://github.com/apache/superset/pull/22849#issuecomment-1511622294
Does WEBDRIVER_BASEURL need to end in a slash? Mine does not in my config and reports etc. all work correctly, I have `WEBDRIVER_BASEURL="http://superset_app:8088"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] sfirke commented on pull request #22849: chore(config): remove/update unused webserver config
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on PR #22849:
URL: https://github.com/apache/superset/pull/22849#issuecomment-1525821788
Bumping this since I see someone is getting confused by the out-of-date docs that this would have fixed: https://github.com/apache/superset/pull/22849 Maybe merge this to fix the docs, then address the suggestion from @Antonio-RiveroMartnez about fixing trailing URLs in a different PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(cache): remove unused webserver config & handle trailing slashes [superset]
Posted by "john-bodley (via GitHub)" <gi...@apache.org>.
john-bodley commented on PR #22849:
URL: https://github.com/apache/superset/pull/22849#issuecomment-1828368592
cc @eschutho and @michael-s-molina as these unused config variables were never previously referenced in `UPDATING.md` as being deprecated and/or obsolete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Antonio-RiveroMartnez commented on a diff in pull request #22849: chore(config): remove/update unused webserver config
Posted by "Antonio-RiveroMartnez (via GitHub)" <gi...@apache.org>.
Antonio-RiveroMartnez commented on code in PR #22849:
URL: https://github.com/apache/superset/pull/22849#discussion_r1171890879
##########
docs/docs/installation/alerts-reports.mdx:
##########
@@ -163,9 +163,9 @@ WEBDRIVER_OPTION_ARGS = [
]
# This is for internal use, you can keep http
-WEBDRIVER_BASEURL = "http://superset:8088"
-# This is the link sent to the recipient. Change to your domain, e.g. https://superset.mydomain.com
-WEBDRIVER_BASEURL_USER_FRIENDLY = "http://localhost:8088"
+WEBDRIVER_BASEURL = "http://superset:8088/"
Review Comment:
Hey! Thanks for the fix! π just a comment, could we leave this as is and instead address the correct handling of both cases (with our without trailing /) in the get_url method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Usiel commented on pull request #22849: chore(config): remove/update unused webserver config
Posted by "Usiel (via GitHub)" <gi...@apache.org>.
Usiel commented on PR #22849:
URL: https://github.com/apache/superset/pull/22849#issuecomment-1477275588
Just a friendly reminder for this PR (no functional changes).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(cache): removeunused webserver config & handle trailing slashes [superset]
Posted by "Usiel (via GitHub)" <gi...@apache.org>.
Usiel commented on PR #22849:
URL: https://github.com/apache/superset/pull/22849#issuecomment-1815641615
Happy to give this another shot, probably sometime end of next week :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(cache): remove unused webserver config & handle trailing slashes [superset]
Posted by "Usiel (via GitHub)" <gi...@apache.org>.
Usiel commented on PR #22849:
URL: https://github.com/apache/superset/pull/22849#issuecomment-1921305118
> Yes please @Usiel ! If you rebase I will do my best to ping the right committer to review and merge.
Rebased (no conflicts), thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(cache): remove unused webserver config & handle trailing slashes [superset]
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on PR #22849:
URL: https://github.com/apache/superset/pull/22849#issuecomment-1921559704
@john-bodley or @michael-s-molina could you take a look at this, maybe during the daily PR review? It is ready for merge to my eyes but I don't know enough to evaluate the tests.
I don't think it's a problem that in the past, there was a failure to document the removal of the now-unused variables that this cleans up. But if you like, I can make a follow-up PR that adds it retroactively to the 2.0.0 release notes as I propose in my comment above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org