You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/24 19:33:27 UTC

[GitHub] [airflow] potiuk commented on a change in pull request #13308: Adds missing LDAP "extra" dependencies to LDAP provider.

potiuk commented on a change in pull request #13308:
URL: https://github.com/apache/airflow/pull/13308#discussion_r548725115



##########
File path: setup.py
##########
@@ -766,9 +766,9 @@ def write_version(filename: str = os.path.join(*[my_dir, "airflow", "git_version
     'jdbc': ["jdbc"],
     'jenkins': ["jenkins"],
     'jira': ["jira"],
-    'kerberos': [],
+    'kerberos': ["kerberos"],

Review comment:
       In our case extras <> providers. We have  quite a few more extras than providers . We need to refactor setup.py badly  to reflect that because it is awfully confusing (includig myself as you see) . We already discussed it in #12548 and I am going to do this very thing before New Year. I created #13309 to not forget about it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org