[GitHub] [aurora] rdelval commented on a change in pull request #67: Adding flag to enable SLA aware killing for non production workloads.

[GitBox <gi...@apache.org>]

rdelval commented on a change in pull request #67: Adding flag to enable SLA aware killing for non production workloads.
URL: https://github.com/apache/aurora/pull/67#discussion_r321361803
 
 

 ##########
 File path: src/main/java/org/apache/aurora/scheduler/sla/SlaManager.java
 ##########
 @@ -445,8 +449,7 @@ private void incrementErrorCount(String prefix, String taskKey) {
   }
 
   private boolean skipSla(IScheduledTask task, long numActive) {
-    if (!tierManager.getTier(task.getAssignedTask().getTask()).isPreemptible()
-        && !tierManager.getTier(task.getAssignedTask().getTask()).isRevocable()) {
+    if (slaAwareKillNonProd || task.getAssignedTask().getTask().isProduction()) {
 
 Review comment:
   This is actually just a helper function introduced recently [here](https://github.com/apache/aurora/commit/c1791d6f94b7a98cdcecb3b70a8655f5320c3e58#diff-e6e423af634fb11298fbc8daa14eaa58R70) to help us cope with the fact that the migration to tiers was started but (in my opinion) never carried out in a straight forward manner.
   
   So the code is doing exactly what you asked :slightly_smiling_face: 
   
   I can change it back if you think it makes it easier to understand, however.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services