You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "bvolpato (via GitHub)" <gi...@apache.org> on 2026/09/01 05:28:46 UTC
[PR] [Python] Configure object detection benchmark timeout [beam]
bvolpato opened a new pull request, #39949:
URL: https://github.com/apache/beam/pull/39949
Addresses #38782.
## Why
The Faster R-CNN benchmark added in #37186 has not completed successfully in the daily workflow. Recent runs consistently reach the object-detection batch CPU step, start the Dataflow job, and then cancel it after about 1,803 seconds.
This is not the GitHub Actions timeout. Each benchmark step allows 180 minutes, but `pytorch_image_object_detection.run()` has its own hard-coded 30-minute `wait_until_finish()` call. Its `finally` block cancels the still-running Dataflow job before the outer workflow timeout can help.
## What changed
* Add a `--timeout_ms` option to the object-detection example, preserving the existing 30-minute default for other callers.
* Set this benchmark's timeout to 60 minutes. This doubles the observed failing limit while retaining a two-hour guard before the workflow step timeout.
Keeping the override in the benchmark options makes future runtime tuning possible without changing example behavior globally.
## Validation
* `python -m py_compile sdks/python/apache_beam/examples/inference/pytorch_image_object_detection.py`
* `yapf==0.43.0 --diff` on the changed Python file
* `ruff==0.15.22 check --ignore I001,UP006` on the changed Python file. Remaining ignored findings predate this change.
* `git diff --check`
End-to-end validation requires the Dataflow benchmark infrastructure, so this remains draft until CI and a workflow run can validate the increased budget.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Python] Configure object detection benchmark timeout [beam]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #39949:
URL: https://github.com/apache/beam/pull/39949#issuecomment-6069047563
## [Codecov](https://app.codecov.io/gh/apache/beam/pull/39949?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 56.20%. Comparing base ([`76f6e6d`](https://app.codecov.io/gh/apache/beam/commit/76f6e6d7c0c1b2ce582c73d068ad9260cf15c5f3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`242190c`](https://app.codecov.io/gh/apache/beam/commit/242190c1f3e6b4389b2440f6caeb3007e0af19c4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 98 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #39949 +/- ##
============================================
+ Coverage 56.16% 56.20% +0.03%
Complexity 2288 2288
============================================
Files 1124 1124
Lines 178336 178343 +7
Branches 1489 1489
============================================
+ Hits 100170 100230 +60
+ Misses 75645 75592 -53
Partials 2521 2521
```
| [Flag](https://app.codecov.io/gh/apache/beam/pull/39949/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [python](https://app.codecov.io/gh/apache/beam/pull/39949/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `79.62% <ø> (+0.06%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/beam/pull/39949?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Python] Configure object detection benchmark timeout [beam]
Posted by "bvolpato (via GitHub)" <gi...@apache.org>.
bvolpato commented on PR #39949:
URL: https://github.com/apache/beam/pull/39949#issuecomment-5531811693
The failed Python 3.10 wheel job completed the build and auditwheel repair, then timed out during cibuildwheel's Docker cleanup. I did not find a build failure related to this change.
Could someone with rerun access retry [that job](https://github.com/apache/beam/actions/runs/33473756853/job/99748885826)? My fork account cannot rerun upstream Actions. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org