You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Niklas Nielsen <ni...@qni.dk> on 2015/12/02 19:13:50 UTC
Re: Review Request 37540: Add perf event API
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37540/#review108686
-----------------------------------------------------------
Ping - Cong, is there anything you need to close the last issues? :)
- Niklas Nielsen
On Sept. 29, 2015, 5:12 p.m., Cong Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37540/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2015, 5:12 p.m.)
>
>
> Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-2769
> https://issues.apache.org/jira/browse/MESOS-2769
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Abstract Linux kernel perf event API and provide API to collect schedule events.
>
>
> Diffs
> -----
>
> src/linux/perf.hpp d10968ca670eb516bae08385fd0ddde8e8ad83b5
> src/linux/perf.cpp f7035ddb2507a7646d88dd517d048018f695448a
> src/tests/containerizer/perf_tests.cpp ed5212ee31b8aa47339b8b8fab184bbdf85be82a
>
> Diff: https://reviews.apache.org/r/37540/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Cong Wang
>
>
Re: Review Request 37540: Add perf event API
Posted by Niklas Nielsen <ni...@qni.dk>.
> On Dec. 2, 2015, 10:13 a.m., Niklas Nielsen wrote:
> > Ping - Cong, is there anything you need to close the last issues? :)
>
> Cong Wang wrote:
> I was blocked at the second to the last issue above and switched to something else, now I can think more about it. Thanks!
Sweet! Let us know when you are ready for new review rounds :)
- Niklas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37540/#review108686
-----------------------------------------------------------
On Sept. 29, 2015, 5:12 p.m., Cong Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37540/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2015, 5:12 p.m.)
>
>
> Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-2769
> https://issues.apache.org/jira/browse/MESOS-2769
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Abstract Linux kernel perf event API and provide API to collect schedule events.
>
>
> Diffs
> -----
>
> src/linux/perf.hpp d10968ca670eb516bae08385fd0ddde8e8ad83b5
> src/linux/perf.cpp f7035ddb2507a7646d88dd517d048018f695448a
> src/tests/containerizer/perf_tests.cpp ed5212ee31b8aa47339b8b8fab184bbdf85be82a
>
> Diff: https://reviews.apache.org/r/37540/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Cong Wang
>
>
Re: Review Request 37540: Add perf event API
Posted by Cong Wang <cw...@twopensource.com>.
> On Dec. 2, 2015, 6:13 p.m., Niklas Nielsen wrote:
> > Ping - Cong, is there anything you need to close the last issues? :)
I was blocked at the second to the last issue above and switched to something else, now I can think more about it. Thanks!
- Cong
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37540/#review108686
-----------------------------------------------------------
On Sept. 30, 2015, 12:12 a.m., Cong Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37540/
> -----------------------------------------------------------
>
> (Updated Sept. 30, 2015, 12:12 a.m.)
>
>
> Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-2769
> https://issues.apache.org/jira/browse/MESOS-2769
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Abstract Linux kernel perf event API and provide API to collect schedule events.
>
>
> Diffs
> -----
>
> src/linux/perf.hpp d10968ca670eb516bae08385fd0ddde8e8ad83b5
> src/linux/perf.cpp f7035ddb2507a7646d88dd517d048018f695448a
> src/tests/containerizer/perf_tests.cpp ed5212ee31b8aa47339b8b8fab184bbdf85be82a
>
> Diff: https://reviews.apache.org/r/37540/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Cong Wang
>
>