You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/04/13 17:28:57 UTC
[GitHub] [accumulo] Manno15 opened a new pull request #2015: Pom changes to allow reuseForks to be set to true
Manno15 opened a new pull request #2015:
URL: https://github.com/apache/accumulo/pull/2015
Fix the issues caused by #2007. Currently, the main accumulo pom will exclude the tests that do not work with reuseForks being true. These tests are included in a separate configuration (located in the package pom that each test belongs to for the moment) of the `maven-surefire-plugin` with reuseForks set to false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii edited a comment on pull request #2015: Pom changes to allow reuseForks to be set to true
Posted by GitBox <gi...@apache.org>.
ctubbsii edited a comment on pull request #2015:
URL: https://github.com/apache/accumulo/pull/2015#issuecomment-819282264
In order to run the problematic tests with `reuseForks=true` set for the others, you'll need to exclude these classes from the main configuration of `maven-surefire-plugin` with `<excludes>` (this can be done in core/pom.xml and server/tserver/pom.xml, rather than the root pom.xml, where you've made the current changes), and then you will need to have an additional execution of the surefire plugin, as in the following (not complete):
```xml
<build>
<plugins>
<plugin>
<artifactId>maven-surefire-plugin</artifactId>
<executions>
<execution>
<id>no-reuse-forks-tests</id>
<goals>
<goal>test</goal>
</goals>
<configuration>
<reuseForks>false</reuseForks>
<includes />
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</build>
```
What I'm not sure about is whether the plugin's second execution will clobber any test output from the previous (default, built-in) execution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] Manno15 merged pull request #2015: Pom changes to allow reuseForks to be set to true
Posted by GitBox <gi...@apache.org>.
Manno15 merged pull request #2015:
URL: https://github.com/apache/accumulo/pull/2015
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on a change in pull request #2015: Pom changes to allow reuseForks to be set to true
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #2015:
URL: https://github.com/apache/accumulo/pull/2015#discussion_r617029427
##########
File path: pom.xml
##########
@@ -822,6 +822,30 @@
</systemPropertyVariables>
<argLine>${unitTestMemSize}</argLine>
</configuration>
+ <executions>
+ <execution>
+ <id>reuseForks-false-tests</id>
+ <goals>
+ <goal>test</goal>
+ </goals>
+ <configuration>
+ <forkCount>${surefire.forkCount}</forkCount>
+ <reuseForks>false</reuseForks>
+ <includes>
+ <include>**/TableIdTest.java</include>
+ <include>**/HadoopCredentialProviderTest.java</include>
+ <include>**/IdleRatioScanPrioritizerTest.java</include>
+ <include>**/AssignmentWatcherTest.java</include>
+ <include>**/TestCfCqSlice.java</include>
+ <include>**/TestCfCqSliceSeekingFilter.java</include>
+ </includes>
+ <systemPropertyVariables>
+ <java.io.tmpdir>${project.build.directory}</java.io.tmpdir>
+ </systemPropertyVariables>
+ <argLine>${unitTestMemSize}</argLine>
Review comment:
You could try adding `<excludes combine.self=”override” />` to the second execution to prevent the excludes from being inherited. I haven't tried this yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] Manno15 commented on pull request #2015: Pom changes to allow reuseForks to be set to true
Posted by GitBox <gi...@apache.org>.
Manno15 commented on pull request #2015:
URL: https://github.com/apache/accumulo/pull/2015#issuecomment-820525793
I added the exception as you suggested. Everything passes locally though it is hanging on the QA check which is unrelated. It is hard to verify that the second execution is running, so I am unsure if I did it correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] Manno15 commented on pull request #2015: Pom changes to allow reuseForks to be set to true
Posted by GitBox <gi...@apache.org>.
Manno15 commented on pull request #2015:
URL: https://github.com/apache/accumulo/pull/2015#issuecomment-828489008
So i did see `AuthenticationTokenSecretManagerTest` again. The error seems related to reuseForks, I will add it to the list to be safe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] Manno15 commented on pull request #2015: Pom changes to allow reuseForks to be set to true
Posted by GitBox <gi...@apache.org>.
Manno15 commented on pull request #2015:
URL: https://github.com/apache/accumulo/pull/2015#issuecomment-828381461
I believe I have seen `AuthenticationTokenSecretManagerTest` fail before but it is never consistent. I think I have seen it fail before this change but I am not quite sure there. I can look into it more and possibly had it to the excluded list if is an issue.
At a glance, it does seem likely `DefaultKeySizeConstraintTest` is related to it but I haven't seen that one fail myself so I will need to take a closer look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] Manno15 commented on a change in pull request #2015: Pom changes to allow reuseForks to be set to true
Posted by GitBox <gi...@apache.org>.
Manno15 commented on a change in pull request #2015:
URL: https://github.com/apache/accumulo/pull/2015#discussion_r614959290
##########
File path: pom.xml
##########
@@ -822,6 +822,30 @@
</systemPropertyVariables>
<argLine>${unitTestMemSize}</argLine>
</configuration>
+ <executions>
+ <execution>
+ <id>reuseForks-false-tests</id>
+ <goals>
+ <goal>test</goal>
+ </goals>
+ <configuration>
+ <forkCount>${surefire.forkCount}</forkCount>
+ <reuseForks>false</reuseForks>
+ <includes>
+ <include>**/TableIdTest.java</include>
+ <include>**/HadoopCredentialProviderTest.java</include>
+ <include>**/IdleRatioScanPrioritizerTest.java</include>
+ <include>**/AssignmentWatcherTest.java</include>
+ <include>**/TestCfCqSlice.java</include>
+ <include>**/TestCfCqSliceSeekingFilter.java</include>
+ </includes>
+ <systemPropertyVariables>
+ <java.io.tmpdir>${project.build.directory}</java.io.tmpdir>
+ </systemPropertyVariables>
+ <argLine>${unitTestMemSize}</argLine>
Review comment:
I see the second execution Id in the logs but I do not see it actively running any tests. Not quite sure what is going on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] Manno15 commented on pull request #2015: Pom changes to allow reuseForks to be set to true
Posted by GitBox <gi...@apache.org>.
Manno15 commented on pull request #2015:
URL: https://github.com/apache/accumulo/pull/2015#issuecomment-823951031
> I guess my main question at this point is: if a failure is introduced in the first execution, or in the second, does the plugin behave properly by failing the build and preserving the logs for the failed tests. Have you checked to see what happens when you introduce a failure in the first execution? The second?
I will do more explicit testing today. From my observations though, everything appears to be running as expected. The second execution doesn't overwrite any logs and it has inherited all of the properties of the first execution so it behaves the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] Manno15 commented on a change in pull request #2015: Pom changes to allow reuseForks to be set to true
Posted by GitBox <gi...@apache.org>.
Manno15 commented on a change in pull request #2015:
URL: https://github.com/apache/accumulo/pull/2015#discussion_r614822761
##########
File path: pom.xml
##########
@@ -822,6 +822,30 @@
</systemPropertyVariables>
<argLine>${unitTestMemSize}</argLine>
</configuration>
+ <executions>
+ <execution>
+ <id>reuseForks-false-tests</id>
+ <goals>
+ <goal>test</goal>
+ </goals>
+ <configuration>
+ <forkCount>${surefire.forkCount}</forkCount>
+ <reuseForks>false</reuseForks>
+ <includes>
+ <include>**/TableIdTest.java</include>
+ <include>**/HadoopCredentialProviderTest.java</include>
+ <include>**/IdleRatioScanPrioritizerTest.java</include>
+ <include>**/AssignmentWatcherTest.java</include>
+ <include>**/TestCfCqSlice.java</include>
+ <include>**/TestCfCqSliceSeekingFilter.java</include>
+ </includes>
+ <systemPropertyVariables>
+ <java.io.tmpdir>${project.build.directory}</java.io.tmpdir>
+ </systemPropertyVariables>
+ <argLine>${unitTestMemSize}</argLine>
Review comment:
I made the changes for points 1 and 2.
> Need to double check that the second execution doesn't clobber the reports generated by the first execution. Hopefully, it only adds new reports, and doesn't clobber, but I haven't checked.
I am looking into all the reporting now to be sure. Everything from the default execution seems to be normal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] Manno15 commented on pull request #2015: Pom changes to allow reuseForks to be set to true
Posted by GitBox <gi...@apache.org>.
Manno15 commented on pull request #2015:
URL: https://github.com/apache/accumulo/pull/2015#issuecomment-823286096
Everything passes now and I confirmed the tests run. Had to add a line to reset the exclude tag after the initial execution finished. Overall, barely any time was added with the second execution (if any at all).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] Manno15 commented on a change in pull request #2015: Pom changes to allow reuseForks to be set to true
Posted by GitBox <gi...@apache.org>.
Manno15 commented on a change in pull request #2015:
URL: https://github.com/apache/accumulo/pull/2015#discussion_r617476248
##########
File path: pom.xml
##########
@@ -822,6 +822,30 @@
</systemPropertyVariables>
<argLine>${unitTestMemSize}</argLine>
</configuration>
+ <executions>
+ <execution>
+ <id>reuseForks-false-tests</id>
+ <goals>
+ <goal>test</goal>
+ </goals>
+ <configuration>
+ <forkCount>${surefire.forkCount}</forkCount>
+ <reuseForks>false</reuseForks>
+ <includes>
+ <include>**/TableIdTest.java</include>
+ <include>**/HadoopCredentialProviderTest.java</include>
+ <include>**/IdleRatioScanPrioritizerTest.java</include>
+ <include>**/AssignmentWatcherTest.java</include>
+ <include>**/TestCfCqSlice.java</include>
+ <include>**/TestCfCqSliceSeekingFilter.java</include>
+ </includes>
+ <systemPropertyVariables>
+ <java.io.tmpdir>${project.build.directory}</java.io.tmpdir>
+ </systemPropertyVariables>
+ <argLine>${unitTestMemSize}</argLine>
Review comment:
This worked, I will go with it since it is shorter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on pull request #2015: Pom changes to allow reuseForks to be set to true
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #2015:
URL: https://github.com/apache/accumulo/pull/2015#issuecomment-830667514
Keep in mind that this change is not necessarily the cause of these failures, but may have helped reveal them. The failures may indicate existing concurrency issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] Manno15 commented on pull request #2015: Pom changes to allow reuseForks to be set to true
Posted by GitBox <gi...@apache.org>.
Manno15 commented on pull request #2015:
URL: https://github.com/apache/accumulo/pull/2015#issuecomment-818915204
@ctubbsii I wanted to get my current work out there so you could give some thoughts on it. I am still looking into the separate execution of the `maven-surefire-plugin` which is why this is only a draft for the moment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on pull request #2015: Pom changes to allow reuseForks to be set to true
Posted by GitBox <gi...@apache.org>.
milleruntime commented on pull request #2015:
URL: https://github.com/apache/accumulo/pull/2015#issuecomment-831392581
> Keep in mind that this change is not necessarily the cause of these failures, but may have helped reveal them. The failures may indicate existing concurrency issues.
Possibly. But it seems more likely it is just breaking tests that were not written to run concurrently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] Manno15 commented on a change in pull request #2015: Pom changes to allow reuseForks to be set to true
Posted by GitBox <gi...@apache.org>.
Manno15 commented on a change in pull request #2015:
URL: https://github.com/apache/accumulo/pull/2015#discussion_r614959290
##########
File path: pom.xml
##########
@@ -822,6 +822,30 @@
</systemPropertyVariables>
<argLine>${unitTestMemSize}</argLine>
</configuration>
+ <executions>
+ <execution>
+ <id>reuseForks-false-tests</id>
+ <goals>
+ <goal>test</goal>
+ </goals>
+ <configuration>
+ <forkCount>${surefire.forkCount}</forkCount>
+ <reuseForks>false</reuseForks>
+ <includes>
+ <include>**/TableIdTest.java</include>
+ <include>**/HadoopCredentialProviderTest.java</include>
+ <include>**/IdleRatioScanPrioritizerTest.java</include>
+ <include>**/AssignmentWatcherTest.java</include>
+ <include>**/TestCfCqSlice.java</include>
+ <include>**/TestCfCqSliceSeekingFilter.java</include>
+ </includes>
+ <systemPropertyVariables>
+ <java.io.tmpdir>${project.build.directory}</java.io.tmpdir>
+ </systemPropertyVariables>
+ <argLine>${unitTestMemSize}</argLine>
Review comment:
I see the second execution Id in the logs but I do not see it actively running any tests. Not quite sure what is going on. I actively tested this by making the second execution's `reuseForks` to true and had no errors when running locally or with Github Actions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on a change in pull request #2015: Pom changes to allow reuseForks to be set to true
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #2015:
URL: https://github.com/apache/accumulo/pull/2015#discussion_r614456377
##########
File path: pom.xml
##########
@@ -822,6 +822,30 @@
</systemPropertyVariables>
<argLine>${unitTestMemSize}</argLine>
</configuration>
+ <executions>
+ <execution>
+ <id>reuseForks-false-tests</id>
+ <goals>
+ <goal>test</goal>
+ </goals>
+ <configuration>
+ <forkCount>${surefire.forkCount}</forkCount>
+ <reuseForks>false</reuseForks>
+ <includes>
+ <include>**/TableIdTest.java</include>
+ <include>**/HadoopCredentialProviderTest.java</include>
+ <include>**/IdleRatioScanPrioritizerTest.java</include>
+ <include>**/AssignmentWatcherTest.java</include>
+ <include>**/TestCfCqSlice.java</include>
+ <include>**/TestCfCqSliceSeekingFilter.java</include>
+ </includes>
+ <systemPropertyVariables>
+ <java.io.tmpdir>${project.build.directory}</java.io.tmpdir>
+ </systemPropertyVariables>
+ <argLine>${unitTestMemSize}</argLine>
Review comment:
This looks like it could work, but there's a few things:
1. I don't think it's necessary to include configuration in this specific execution that is already okay at the level above, directly under the plugin, because it *should* inherit it from there. So, the system properties, forkCount, and argLine can probably be omitted.
2. Declaring the second execution in the root pom will make it execute for every module, even if there's no files in that module that would match the pattern. This might be okay if it's not too costly. Otherwise, it might be worth placing this in each child pom that has matching files that would be affected.
3. Need to double check that the second execution doesn't clobber the reports generated by the first execution. Hopefully, it only adds new reports, and doesn't clobber, but I haven't checked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] Manno15 edited a comment on pull request #2015: Pom changes to allow reuseForks to be set to true
Posted by GitBox <gi...@apache.org>.
Manno15 edited a comment on pull request #2015:
URL: https://github.com/apache/accumulo/pull/2015#issuecomment-828381461
I believe I have seen `AuthenticationTokenSecretManagerTest` fail before but it is never consistent. I think I have seen it fail before this change but I am not quite sure there. I can look into it more and possibly add it to the excluded list if is an issue.
At a glance, it does seem likely `DefaultKeySizeConstraintTest` is related to it but I haven't seen that one fail myself so I will need to take a closer look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on a change in pull request #2015: Pom changes to allow reuseForks to be set to true
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #2015:
URL: https://github.com/apache/accumulo/pull/2015#discussion_r615009193
##########
File path: pom.xml
##########
@@ -822,6 +822,30 @@
</systemPropertyVariables>
<argLine>${unitTestMemSize}</argLine>
</configuration>
+ <executions>
+ <execution>
+ <id>reuseForks-false-tests</id>
+ <goals>
+ <goal>test</goal>
+ </goals>
+ <configuration>
+ <forkCount>${surefire.forkCount}</forkCount>
+ <reuseForks>false</reuseForks>
+ <includes>
+ <include>**/TableIdTest.java</include>
+ <include>**/HadoopCredentialProviderTest.java</include>
+ <include>**/IdleRatioScanPrioritizerTest.java</include>
+ <include>**/AssignmentWatcherTest.java</include>
+ <include>**/TestCfCqSlice.java</include>
+ <include>**/TestCfCqSliceSeekingFilter.java</include>
+ </includes>
+ <systemPropertyVariables>
+ <java.io.tmpdir>${project.build.directory}</java.io.tmpdir>
+ </systemPropertyVariables>
+ <argLine>${unitTestMemSize}</argLine>
Review comment:
You can try troubleshooting by executing with debug mode in Maven. I believe the flag for that is `mvn -X`. Warning: it's quite spammy. Expect to do a lot of scrolling, or pipe the output to a file for inspection after it runs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] Manno15 commented on a change in pull request #2015: Pom changes to allow reuseForks to be set to true
Posted by GitBox <gi...@apache.org>.
Manno15 commented on a change in pull request #2015:
URL: https://github.com/apache/accumulo/pull/2015#discussion_r616052844
##########
File path: pom.xml
##########
@@ -822,6 +822,30 @@
</systemPropertyVariables>
<argLine>${unitTestMemSize}</argLine>
</configuration>
+ <executions>
+ <execution>
+ <id>reuseForks-false-tests</id>
+ <goals>
+ <goal>test</goal>
+ </goals>
+ <configuration>
+ <forkCount>${surefire.forkCount}</forkCount>
+ <reuseForks>false</reuseForks>
+ <includes>
+ <include>**/TableIdTest.java</include>
+ <include>**/HadoopCredentialProviderTest.java</include>
+ <include>**/IdleRatioScanPrioritizerTest.java</include>
+ <include>**/AssignmentWatcherTest.java</include>
+ <include>**/TestCfCqSlice.java</include>
+ <include>**/TestCfCqSliceSeekingFilter.java</include>
+ </includes>
+ <systemPropertyVariables>
+ <java.io.tmpdir>${project.build.directory}</java.io.tmpdir>
+ </systemPropertyVariables>
+ <argLine>${unitTestMemSize}</argLine>
Review comment:
The issue seems to stem from the fact it is inheriting the excluded tests from the parent configuration. So it excludes what I am trying to include. Not sure on the correct way to reset it at this moment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on pull request #2015: Pom changes to allow reuseForks to be set to true
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #2015:
URL: https://github.com/apache/accumulo/pull/2015#issuecomment-819282264
In order to run the problematic tests with `reuseForks=true` set for the others, you'll need to exclude these classes from the main configuration of `maven-surefire-plugin` with `<excludes>` (this can be done in core/pom.xml and server/tserver/pom.xml, rather than the root pom.xml, where you've made the current changes), and then you will need to have an additional execution of the surefire plugin, as in the following (not complete):
```xml
<build>
<plugins>
<plugin>
<artifactId>maven-surefire-plugin</artifactId>
<executions>
<execution>
<id>no-reuse-forks-tests</id>
<goals>
<goal>test</goal>
</goals>
<configuration>
<reuseForks>false</reuseForks>
<includes />
</configuration>
</plugin>
</plugins>
</build>
```
What I'm not sure about is whether the plugin's second execution will clobber any test output from the previous (default, built-in) execution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] Manno15 commented on pull request #2015: Pom changes to allow reuseForks to be set to true
Posted by GitBox <gi...@apache.org>.
Manno15 commented on pull request #2015:
URL: https://github.com/apache/accumulo/pull/2015#issuecomment-824047596
When a failure is introduced in the first execution, the build properly fails and all logs are preserved. The second execution does not start.
When a failure is introduced in the second execution, the build fails after the second execution as expected. All logs are still preserved, including the first execution logs. This is true for both accumulo-core tests and accumulo-tserver tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on pull request #2015: Pom changes to allow reuseForks to be set to true
Posted by GitBox <gi...@apache.org>.
milleruntime commented on pull request #2015:
URL: https://github.com/apache/accumulo/pull/2015#issuecomment-828379142
I am seeing random, inexplicable failures in Unit tests and wondering if its related to the use of `resuseForks`. On my PR #1985 one test will randomly fail only when run with all unit tests, `DefaultKeySizeConstraintTest`. It appears to be related to my change but I can't figure out why it fails. While trying to debug it, I saw another unrelated Unit test fail.
<pre>
[ERROR] AuthenticationTokenSecretManagerTest.testVerifyPassword:210 Different tokens for the same user shouldn't have the same password
</pre>
Here is the failure I keep seeing but makes me think its related to `reuseForks`:
<pre>
[ERROR] DefaultKeySizeConstraintTest.testConstraint:44 expected:<[]> but was:<[2]>
</pre>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org