You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Piotr Kozikowski (JIRA)" <ji...@apache.org> on 2008/11/16 23:36:47 UTC

[jira] Updated: (THRIFT-39) javabean-style generated code is very poorly formatted

     [ https://issues.apache.org/jira/browse/THRIFT-39?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Piotr Kozikowski updated THRIFT-39:
-----------------------------------

    Attachment: thrift-39.patch

I found it! Here is the patch. The fix required only one line of code. If you are curious, what caused this was that in certain situations a call was made to indent_down(), without a corresponding call to indent_up() somewhere before, giving the private variable indent_ a negative value, and making calls to indent() have no effect. 

> javabean-style generated code is very poorly formatted
> ------------------------------------------------------
>
>                 Key: THRIFT-39
>                 URL: https://issues.apache.org/jira/browse/THRIFT-39
>             Project: Thrift
>          Issue Type: Bug
>          Components: Compiler (Java)
>            Reporter: Bryan Duxbury
>            Priority: Trivial
>         Attachments: thrift-39.patch
>
>
> The code that gets generated when you run thrift -javabean has no indentation in it at all. This makes it a little challenging to read through it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.