You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/15 08:51:46 UTC

[GitHub] [flink] HuangXingBo opened a new pull request #12164: [FLINK-17722][python][build system] Keeps flink-sql-client_*.jar in CachedFiles

HuangXingBo opened a new pull request #12164:
URL: https://github.com/apache/flink/pull/12164


   ## What is the purpose of the change
   
   *This pull request will keep flink-sql-client_*.jar in CachedFiles so that we can build a wheel package with the flink-sql-client_*.jar*
   
   
   ## Brief change log
   
     - *add the logic of keeping flink-sql-client_*.jar in cachedFiles*
   
   ## Verifying this change
   
   *This test can only test in nightly build. I will test in my free Azure account*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable=)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] dianfu commented on pull request #12164: [FLINK-17722][python][build system] Keeps flink-sql-client_*.jar in CachedFiles

Posted by GitBox <gi...@apache.org>.
dianfu commented on pull request #12164:
URL: https://github.com/apache/flink/pull/12164#issuecomment-629139793


   @HuangXingBo Thanks for the PR and sharing the test results. The task "build_wheels linux" and "build_wheels mac" have succeeded in the shared link and so I think this PR should have addressed the problem. LGTM and merging...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] HuangXingBo commented on pull request #12164: [FLINK-17722][python][build system] Keeps flink-sql-client_*.jar in CachedFiles

Posted by GitBox <gi...@apache.org>.
HuangXingBo commented on pull request #12164:
URL: https://github.com/apache/flink/pull/12164#issuecomment-629121436


   It is the nightly build in my free Azure account. https://dev.azure.com/hxbks2ks/FLINK-TEST/_build/results?buildId=254&view=results


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12164: [FLINK-17722][python][build system] Keeps flink-sql-client_*.jar in CachedFiles

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12164:
URL: https://github.com/apache/flink/pull/12164#issuecomment-629124220


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6e4242be2ddff26fbf532f9ca514594b62230818",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6e4242be2ddff26fbf532f9ca514594b62230818",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6e4242be2ddff26fbf532f9ca514594b62230818 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] dianfu closed pull request #12164: [FLINK-17722][python][build system] Keeps flink-sql-client_*.jar in CachedFiles

Posted by GitBox <gi...@apache.org>.
dianfu closed pull request #12164:
URL: https://github.com/apache/flink/pull/12164


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12164: [FLINK-17722][python][build system] Keeps flink-sql-client_*.jar in CachedFiles

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12164:
URL: https://github.com/apache/flink/pull/12164#issuecomment-629117920


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 6e4242be2ddff26fbf532f9ca514594b62230818 (Fri May 15 08:55:09 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-17722).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12164: [FLINK-17722][python][build system] Keeps flink-sql-client_*.jar in CachedFiles

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12164:
URL: https://github.com/apache/flink/pull/12164#issuecomment-629124220


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6e4242be2ddff26fbf532f9ca514594b62230818",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1408",
       "triggerID" : "6e4242be2ddff26fbf532f9ca514594b62230818",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6e4242be2ddff26fbf532f9ca514594b62230818 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1408) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org