You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by YunFeng Ma <yu...@yahoo.com> on 2007/06/25 13:59:06 UTC
Why printStackTrace() in the source codes
I just had a search of "printStackTrace()" to the
geronimo source codes and found some classes use this
code. Why don't use org.apache.commons.logging.Log to
trace the exception. org.apache.commons.logging.Log
can print the exception stack trace in the console and
at same time save it to geronimo.log. It will be very
useful for users once he/she closed the geronimo
console or he/she run geronimo as daemon process.
What's your thought? If you think it's useful, I'll
provide a patch.
Thanks
YunFeng Ma
____________________________________________________________________________________
Need Mail bonding?
Go to the Yahoo! Mail Q&A for great tips from Yahoo! Answers users.
http://answers.yahoo.com/dir/?link=list&sid=396546091
Re: Why printStackTrace() in the source codes
Posted by Kevan Miller <ke...@gmail.com>.
On Jun 25, 2007, at 7:59 AM, YunFeng Ma wrote:
> I just had a search of "printStackTrace()" to the
> geronimo source codes and found some classes use this
> code. Why don't use org.apache.commons.logging.Log to
> trace the exception. org.apache.commons.logging.Log
> can print the exception stack trace in the console and
> at same time save it to geronimo.log. It will be very
> useful for users once he/she closed the geronimo
> console or he/she run geronimo as daemon process.
>
> What's your thought? If you think it's useful, I'll
> provide a patch.
Not having looked, if the code is not junit/testsuite code and it's
running after we've set up our logging config, then I'd agree that it
should not be using printStackTrace to print to STDERR. Create a jira
and attach your patch...
--kevan