You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "leandron (via GitHub)" <gi...@apache.org> on 2023/03/09 16:33:13 UTC

[GitHub] [tvm] leandron commented on a diff in pull request #14231: Enable onednn in tvm.

leandron commented on code in PR #14231:
URL: https://github.com/apache/tvm/pull/14231#discussion_r1131287421


##########
CMakeLists.txt:
##########
@@ -12,6 +12,8 @@ include(cmake/utils/FindLLVM.cmake)
 include(cmake/utils/FindROCM.cmake)
 include(cmake/utils/FindEthosN.cmake)
 
+set(CMAKE_VERBOSE_MAKEFILE on)

Review Comment:
   Does this need removing as well?



##########
python/tvm/__init__.py:
##########
@@ -32,6 +32,7 @@
 # tvm.runtime
 from .runtime.object import Object
 from .runtime.ndarray import device, cpu, cuda, gpu, opencl, cl, vulkan, metal, mtl
+#from .runtime.ndarray import device, cpu, cuda, sycl, gpu, opencl, cl, vulkan, metal, mtl

Review Comment:
   I think this is a duplicated line that needs to be removed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org