You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "mohamedawnallah (via GitHub)" <gi...@apache.org> on 2025/07/25 19:45:36 UTC
[PR] workflows: run ML tests requiring docker-in-docker environment on `ubuntu-latest` [beam]
mohamedawnallah opened a new pull request, #35698:
URL: https://github.com/apache/beam/pull/35698
## Description
Now that we have support for pytest user markers (#35655), we can extend this functionality to our post/pre commit workflows targeting ML tests on the first iteration mainly for Milvus itests.
## Motivation and Context
https://github.com/apache/beam/pull/35585
https://github.com/apache/beam/pull/35598 (reverted because pytest user markers wasn't allowed back then)
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] workflows: run ML tests requiring docker-in-docker environment on `ubuntu-latest` [beam]
Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad commented on PR #35698:
URL: https://github.com/apache/beam/pull/35698#issuecomment-3134448623
https://github.com/apache/beam/actions/workflows/beam_PreCommit_Python_ML.yml?query=branch%3Amaster looks perm-red now.
@mohamedawnallah
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] workflows: run ML tests requiring docker-in-docker environment on `ubuntu-latest` [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35698:
URL: https://github.com/apache/beam/pull/35698#issuecomment-3120191436
Assigning reviewers:
R: @Abacn for label build.
Note: If you would like to opt out of this review, comment `assign to next reviewer`.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] workflows: run ML tests requiring docker-in-docker environment on `ubuntu-latest` [beam]
Posted by "mohamedawnallah (via GitHub)" <gi...@apache.org>.
mohamedawnallah commented on PR #35698:
URL: https://github.com/apache/beam/pull/35698#issuecomment-3120149617
cc: @damccorm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] workflows: run ML tests requiring docker-in-docker environment on `ubuntu-latest` [beam]
Posted by "mohamedawnallah (via GitHub)" <gi...@apache.org>.
mohamedawnallah commented on PR #35698:
URL: https://github.com/apache/beam/pull/35698#issuecomment-3120165589
I think missed the `matrix` on the workflow job. Resolving it now...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] workflows: run ML tests requiring docker-in-docker environment on `ubuntu-latest` [beam]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on PR #35698:
URL: https://github.com/apache/beam/pull/35698#issuecomment-3120133292
> [!IMPORTANT]
> **Installation incomplete:** to start using Gemini Code Assist, please ask the [organization owner(s)](https://docs.github.com/en/organizations/managing-peoples-access-to-your-organization-with-roles/roles-in-an-organization#organization-owners) to visit the [Gemini Code Assist Admin Console](https://codeassist.google/code-review/login) and sign the Terms of Services.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] workflows: run ML tests requiring docker-in-docker environment on `ubuntu-latest` [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm merged PR #35698:
URL: https://github.com/apache/beam/pull/35698
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] workflows: run ML tests requiring docker-in-docker environment on `ubuntu-latest` [beam]
Posted by "mohamedawnallah (via GitHub)" <gi...@apache.org>.
mohamedawnallah commented on PR #35698:
URL: https://github.com/apache/beam/pull/35698#issuecomment-3134531097
> https://github.com/apache/beam/actions/workflows/beam_PreCommit_Python_ML.yml?query=branch%3Amaster
Yes I see since I have triggered them in this PR. I think it is now fine for current master branch since no tests marked `require_docker_in_docker`. I will investigate this tomorrow 👍
https://github.com/apache/beam/pull/35577
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] workflows: run ML tests requiring docker-in-docker environment on `ubuntu-latest` [beam]
Posted by "mohamedawnallah (via GitHub)" <gi...@apache.org>.
mohamedawnallah commented on PR #35698:
URL: https://github.com/apache/beam/pull/35698#issuecomment-3134605777
just seeing if gemini would catch this earlier
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] workflows: run ML tests requiring docker-in-docker environment on `ubuntu-latest` [beam]
Posted by "mohamedawnallah (via GitHub)" <gi...@apache.org>.
mohamedawnallah commented on PR #35698:
URL: https://github.com/apache/beam/pull/35698#issuecomment-3134605860
/gemini review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] workflows: run ML tests requiring docker-in-docker environment on `ubuntu-latest` [beam]
Posted by "mohamedawnallah (via GitHub)" <gi...@apache.org>.
mohamedawnallah commented on PR #35698:
URL: https://github.com/apache/beam/pull/35698#issuecomment-3120190597
> I think missed the `matrix` on the workflow job. Resolving them now...
Resolved them. I think PR now ready for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] workflows: run ML tests requiring docker-in-docker environment on `ubuntu-latest` [beam]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on PR #35698:
URL: https://github.com/apache/beam/pull/35698#issuecomment-3134605928
> [!NOTE]
> Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org