[jira] [Comment Edited] (YARN-7476) Fix miscellaneous issues in ATSv2 after merge to branch-2

["Subru Krishnan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-7476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248715#comment-16248715 ] 

Subru Krishnan edited comment on YARN-7476 at 11/11/17 11:07 PM:
-----------------------------------------------------------------

Thanks [~varun_saxena] for the thorough investigation to dig this up. I compared the files between trunk and branch-2 and you are spot on, +1 on the patch (pending Yetus).


was (Author: subru):
Thanks [~varun_saxena] for the thorough investigation to dig this up. +1 on the patch (pending Yetus).

> Fix miscellaneous issues in ATSv2 after merge to branch-2
> ---------------------------------------------------------
>
>                 Key: YARN-7476
>                 URL: https://issues.apache.org/jira/browse/YARN-7476
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Varun Saxena
>            Assignee: Varun Saxena
>         Attachments: YARN-7476-branch-2.01.patch
>
>
>     a) We are still using Resource#getMemory in NMTimelinePublisher#publishContainerCreatedEvent. This has been deprecated since YARN-4844. Better to use getMemorySize instead.
>     b) Post YARN-5865, application priority should be fetched from RMAppImpl instead of app submission context. But we are still fetching it from submission context while publishing entities to timeline service. This would mean that if priority is updated, it will not be published to timeline service.
>     c) The order of app_collectors in NodeHeartbeatResponseProto is different from trunk. Better to make it consistent.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org