[GitHub] [pinot] GSharayu commented on a diff in pull request #10623: [feature] API to get table configs in newer format

["GSharayu (via GitHub)" <gi...@apache.org>]

GSharayu commented on code in PR #10623:
URL: https://github.com/apache/pinot/pull/10623#discussion_r1169088438


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/bloom/BloomIndexType.java:
##########
@@ -70,9 +70,14 @@ public BloomFilterConfig getDefaultConfig() {
     return BloomFilterConfig.DISABLED;
   }
 
+  @Override
+  public String getPrettyName() {
+    return "bloom";

Review Comment:
   Can we please extract this name as a constant before? 



##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/forward/ForwardIndexType.java:
##########
@@ -125,6 +125,11 @@ public ForwardIndexConfig getDefaultConfig() {
     return ForwardIndexConfig.DEFAULT;
   }
 
+  @Override
+  public String getPrettyName() {
+    return "forward";

Review Comment:
   Same here, can we please extract the constant before



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org