You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/11/21 16:06:04 UTC

[GitHub] [nifi] exceptionfactory opened a new pull request, #6690: NIFI-10819 Restrict JndiLoginModule for Kafka JAAS Config

exceptionfactory opened a new pull request, #6690:
URL: https://github.com/apache/nifi/pull/6690

   # Summary
   
   [NIFI-10819](https://issues.apache.org/jira/browse/NIFI-10819) Restricts the custom Kafka client property `sasl.jaas.config` to block usage of the `JndiLoginModule` by marking the Processor as invalid. The `JndiLoginModule` is not used for supported, but this approach prevents unexpected and insecure configuration settings.
   
   The implementation applies to Kafka 2.6 components and replaces the `KafkaProcessorUtils` class with discrete interfaces and implementations in a new `nifi-kafka-shared` module. The components in `nifi-kafka-shared` do not have any dependencies on Kafka client libraries. The implementation approach will allow the same refactoring to Kafka 1.0 and 2.0 components, but this pull request limits the scope of Kafka 2.6 to reduce the initial impact of refactoring.
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
   
   ### Pull Request Tracking
   
   - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
   - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
   
   ### Pull Request Formatting
   
   - [X] Pull Request based on current revision of the `main` branch
   - [X] Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request creation.
   
   ### Build
   
   - [X] Build completed using `mvn clean install -P contrib-check`
     - [X] JDK 8
     - [ ] JDK 11
     - [ ] JDK 17
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] gresockj commented on pull request #6690: NIFI-10819 Restrict JndiLoginModule for Kafka JAAS Config

Posted by GitBox <gi...@apache.org>.
gresockj commented on PR #6690:
URL: https://github.com/apache/nifi/pull/6690#issuecomment-1322529773

   Thanks, @exceptionfactory -- reviewing


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] asfgit closed pull request #6690: NIFI-10819 Restrict JndiLoginModule for Kafka JAAS Config

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #6690: NIFI-10819 Restrict JndiLoginModule for Kafka JAAS Config
URL: https://github.com/apache/nifi/pull/6690


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org