You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "David Knupp (Code Review)" <ge...@cloudera.org> on 2020/04/13 21:41:13 UTC
[Impala-ASF-CR] IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download
David Knupp has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15720
Change subject: IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download
......................................................................
IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download
Change-Id: I4ef8203fb31b200b7480a11e148a833f4129dafc
---
M fe/pom.xml
1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/15720/1
--
To view, visit http://gerrit.cloudera.org:8080/15720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4ef8203fb31b200b7480a11e148a833f4129dafc
Gerrit-Change-Number: 15720
Gerrit-PatchSet: 1
Gerrit-Owner: David Knupp <dk...@cloudera.com>
[Impala-ASF-CR] IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15720 )
Change subject: IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5646/
--
To view, visit http://gerrit.cloudera.org:8080/15720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ef8203fb31b200b7480a11e148a833f4129dafc
Gerrit-Change-Number: 15720
Gerrit-PatchSet: 2
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Apr 2020 04:51:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15720 )
Change subject: IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download
......................................................................
Patch Set 3: Code-Review+2
The test failures look unrelated, and everything else builds and runs. I'm going to restart GVO.
--
To view, visit http://gerrit.cloudera.org:8080/15720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ef8203fb31b200b7480a11e148a833f4129dafc
Gerrit-Change-Number: 15720
Gerrit-PatchSet: 3
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Apr 2020 23:39:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15720 )
Change subject: IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download
......................................................................
IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download
These jars have known security vulnerabilities. They are included as part of
Sentry, and are not used by Impala directly.
There's a currently a plan to remove Sentry altogether, but since this will
require non-trivial effort, until that time, let's exclude these items from
the maven download.
Change-Id: I4ef8203fb31b200b7480a11e148a833f4129dafc
Reviewed-on: http://gerrit.cloudera.org:8080/15720
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/pom.xml
1 file changed, 10 insertions(+), 0 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/15720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4ef8203fb31b200b7480a11e148a833f4129dafc
Gerrit-Change-Number: 15720
Gerrit-PatchSet: 5
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15720 )
Change subject: IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5652/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/15720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ef8203fb31b200b7480a11e148a833f4129dafc
Gerrit-Change-Number: 15720
Gerrit-PatchSet: 3
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Apr 2020 23:40:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15720 )
Change subject: IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download
......................................................................
Patch Set 3: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5652/
--
To view, visit http://gerrit.cloudera.org:8080/15720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ef8203fb31b200b7480a11e148a833f4129dafc
Gerrit-Change-Number: 15720
Gerrit-PatchSet: 3
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 Apr 2020 02:51:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15720 )
Change subject: IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15720/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/15720/1//COMMIT_MSG@7
PS1, Line 7: Exclude shiro-core and shiro-crypto-core jars from maven download
> Ack.
Done
--
To view, visit http://gerrit.cloudera.org:8080/15720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ef8203fb31b200b7480a11e148a833f4129dafc
Gerrit-Change-Number: 15720
Gerrit-PatchSet: 2
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 13 Apr 2020 22:49:38 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15720 )
Change subject: IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5796/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ef8203fb31b200b7480a11e148a833f4129dafc
Gerrit-Change-Number: 15720
Gerrit-PatchSet: 1
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 13 Apr 2020 22:22:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15720 )
Change subject: IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download
......................................................................
Patch Set 2:
> Patch Set 2: Verified-1
>
> Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5646/
Seems to be unrelated. I think this is https://issues.apache.org/jira/browse/IMPALA-9596.
--
To view, visit http://gerrit.cloudera.org:8080/15720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ef8203fb31b200b7480a11e148a833f4129dafc
Gerrit-Change-Number: 15720
Gerrit-PatchSet: 2
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Apr 2020 16:21:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15720 )
Change subject: IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ef8203fb31b200b7480a11e148a833f4129dafc
Gerrit-Change-Number: 15720
Gerrit-PatchSet: 4
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 16 Apr 2020 18:53:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15720 )
Change subject: IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download
......................................................................
Patch Set 1:
(1 comment)
> Patch Set 1:
>
> (1 comment)
http://gerrit.cloudera.org:8080/#/c/15720/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/15720/1//COMMIT_MSG@7
PS1, Line 7: Exclude shiro-core and shiro-crypto-core jars from maven download
> The commit message needs details about what is changing, why you are changi
Ack.
Sorry -- left does details in the JIRA, but didn't add them here.
--
To view, visit http://gerrit.cloudera.org:8080/15720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ef8203fb31b200b7480a11e148a833f4129dafc
Gerrit-Change-Number: 15720
Gerrit-PatchSet: 1
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 13 Apr 2020 22:08:34 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15720 )
Change subject: IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download
......................................................................
Patch Set 4:
Failures were unrelated to this patch, retrying
--
To view, visit http://gerrit.cloudera.org:8080/15720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ef8203fb31b200b7480a11e148a833f4129dafc
Gerrit-Change-Number: 15720
Gerrit-PatchSet: 4
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 16 Apr 2020 18:53:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong, Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15720
to look at the new patch set (#2).
Change subject: IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download
......................................................................
IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download
These jars have known security vulnerabilities. They are included as part of
Sentry, and are not used by Impala directly.
There's a currently a plan to remove Sentry altogether, but since this will
require non-trivial effort, until that time, let's exclude these items from
the maven download.
Change-Id: I4ef8203fb31b200b7480a11e148a833f4129dafc
---
M fe/pom.xml
1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/15720/2
--
To view, visit http://gerrit.cloudera.org:8080/15720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4ef8203fb31b200b7480a11e148a833f4129dafc
Gerrit-Change-Number: 15720
Gerrit-PatchSet: 2
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15720 )
Change subject: IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download
......................................................................
Patch Set 2:
This looks good to me. I'm going to run a verify job to see how it goes, then I'll +2.
--
To view, visit http://gerrit.cloudera.org:8080/15720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ef8203fb31b200b7480a11e148a833f4129dafc
Gerrit-Change-Number: 15720
Gerrit-PatchSet: 2
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Apr 2020 00:21:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15720 )
Change subject: IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15720/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/15720/1//COMMIT_MSG@7
PS1, Line 7: Exclude shiro-core and shiro-crypto-core jars from maven download
The commit message needs details about what is changing, why you are changing it, and how you tested it. In this case, we should mention that there are vulnerabilities in the libraries and this is only used by Sentry, which is going to be removed.
--
To view, visit http://gerrit.cloudera.org:8080/15720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ef8203fb31b200b7480a11e148a833f4129dafc
Gerrit-Change-Number: 15720
Gerrit-PatchSet: 1
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 13 Apr 2020 22:06:32 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15720 )
Change subject: IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/15720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ef8203fb31b200b7480a11e148a833f4129dafc
Gerrit-Change-Number: 15720
Gerrit-PatchSet: 4
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 16 Apr 2020 23:09:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15720 )
Change subject: IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5646/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/15720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ef8203fb31b200b7480a11e148a833f4129dafc
Gerrit-Change-Number: 15720
Gerrit-PatchSet: 2
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Apr 2020 00:21:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15720 )
Change subject: IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5663/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/15720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ef8203fb31b200b7480a11e148a833f4129dafc
Gerrit-Change-Number: 15720
Gerrit-PatchSet: 4
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 16 Apr 2020 18:53:08 +0000
Gerrit-HasComments: No