You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/12/29 13:36:11 UTC
[GitHub] [kylin] hit-lacus opened a new pull request #1524: KYLIN-3392 Fix BufferUnderflowException read DecimalAggregator when it is null
hit-lacus opened a new pull request #1524:
URL: https://github.com/apache/kylin/pull/1524
## Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
## Types of changes
What types of changes does your code introduce to Kylin?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [ ] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail
- [ ] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If this change need a document change, I will prepare another pr against the `document` branch
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] lgtm-com[bot] commented on pull request #1524: KYLIN-3392 Fix BufferUnderflowException read DecimalAggregator when it is null
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #1524:
URL: https://github.com/apache/kylin/pull/1524#issuecomment-752409775
This pull request **introduces 1 alert** when merging 09d66680eb9bae85978ebe5afe8d8dc2a074400f into 7cca1c27cd3c2414f7f9b7061009b8a8b55069bf - [view on LGTM.com](https://lgtm.com/projects/g/apache/kylin/rev/pr-b7fc08c1d7413a1327c1a607a5467bf0516efa5b)
**new alerts:**
* 1 for Boxed variable is never null
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] lgtm-com[bot] commented on pull request #1524: KYLIN-3392 Fix BufferUnderflowException read DecimalAggregator when it is null
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #1524:
URL: https://github.com/apache/kylin/pull/1524#issuecomment-752092530
This pull request **introduces 1 alert** when merging 16626beab8cef6a5d300faea2f144b1246d50645 into fe04ca8d3be6c50742246663d6fd6767a568bcf8 - [view on LGTM.com](https://lgtm.com/projects/g/apache/kylin/rev/pr-d678600f0c907af0011ba9b63bf7c447413a2d7c)
**new alerts:**
* 1 for Boxed variable is never null
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus closed pull request #1524: KYLIN-3392 Fix BufferUnderflowException read DecimalAggregator when it is null
Posted by GitBox <gi...@apache.org>.
hit-lacus closed pull request #1524:
URL: https://github.com/apache/kylin/pull/1524
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] codecov-io commented on pull request #1524: KYLIN-3392 Fix BufferUnderflowException read DecimalAggregator when it is null
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1524:
URL: https://github.com/apache/kylin/pull/1524#issuecomment-752141845
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1524?src=pr&el=h1) Report
> Merging [#1524](https://codecov.io/gh/apache/kylin/pull/1524?src=pr&el=desc) (fe04ca8) into [master](https://codecov.io/gh/apache/kylin/commit/fe04ca8d3be6c50742246663d6fd6767a568bcf8?el=desc) (fe04ca8) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/kylin/pull/1524?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1524 +/- ##
=========================================
Coverage 25.44% 25.44%
Complexity 6765 6765
=========================================
Files 1507 1507
Lines 93784 93784
Branches 13132 13132
=========================================
Hits 23867 23867
Misses 67533 67533
Partials 2384 2384
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1524?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1524?src=pr&el=footer). Last update [fe04ca8...16626be](https://codecov.io/gh/apache/kylin/pull/1524?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] lgtm-com[bot] commented on pull request #1524: KYLIN-3392 Fix BufferUnderflowException read DecimalAggregator when it is null
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #1524:
URL: https://github.com/apache/kylin/pull/1524#issuecomment-752392577
This pull request **introduces 1 alert** when merging 73c46e541c09d851c48f3bf937af79d325cb737f into 7cca1c27cd3c2414f7f9b7061009b8a8b55069bf - [view on LGTM.com](https://lgtm.com/projects/g/apache/kylin/rev/pr-5b0e6256a8d7d6031dc814185d9ab4c7898c3e97)
**new alerts:**
* 1 for Boxed variable is never null
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] kyotoYaho commented on a change in pull request #1524: KYLIN-3392 Fix BufferUnderflowException read DecimalAggregator when it is null
Posted by GitBox <gi...@apache.org>.
kyotoYaho commented on a change in pull request #1524:
URL: https://github.com/apache/kylin/pull/1524#discussion_r549907811
##########
File path: core-metadata/src/main/java/org/apache/kylin/metadata/datatype/BigDecimalSerializer.java
##########
@@ -47,8 +47,7 @@ public BigDecimalSerializer(DataType type) {
@Override
public void serialize(BigDecimal value, ByteBuffer out) {
if (value == null) {
- BytesUtil.writeVInt(0, out);
Review comment:
We cannot change the null check logic for backward compatibility
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] kyotoYaho commented on pull request #1524: KYLIN-3392 Fix BufferUnderflowException read DecimalAggregator when it is null
Posted by GitBox <gi...@apache.org>.
kyotoYaho commented on pull request #1524:
URL: https://github.com/apache/kylin/pull/1524#issuecomment-752298704
It's better to refine the generated testing data for IT to introduce nulls for more columns
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org