You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "sarutak (via GitHub)" <gi...@apache.org> on 2023/08/26 11:18:05 UTC

[GitHub] [avro] sarutak opened a new pull request, #2467: AVRO-3846: [Rust] Fix race condition among serde tests

sarutak opened a new pull request, #2467:
URL: https://github.com/apache/avro/pull/2467

   AVRO-3846
   
   ## What is the purpose of the change
   This PR fixes an issue that race condition happens among serde tests named avro_3747*.
   
   
   Sometimes one of tests named avro_3747* fails.
   You can easily reproduce this issue frequently with cargo test like as follows.
   ```
   $ cargo test avro_3747
   ```
   
   The reason is that these tests run concurrently and save/load the same atomic variable.
   So this PR introduces `serial_test` crate and make these tests run in serial.
   
   ## Verifying this change
   Confirmed tests named avro_3747* don't fail.
   
   ## Documentation
   
   - Does this pull request introduce a new feature? (no)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] martin-g commented on pull request #2467: AVRO-3846: [Rust] Fix race condition among serde tests

Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #2467:
URL: https://github.com/apache/avro/pull/2467#issuecomment-1700767340

   Thanks, @sarutak !
   I haven't faced this problem until now but knowing how it works I understand that it is a real issue!
   
   How about using `serial_file(key, "some/path")` instead ? By using `_file` we can group such related tests. Later if we need to have more serial tests we won't need to lock on unrelated problems.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] martin-g merged pull request #2467: AVRO-3846: [Rust] Fix race condition among serde tests

Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g merged PR #2467:
URL: https://github.com/apache/avro/pull/2467


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] sarutak commented on pull request #2467: AVRO-3846: [Rust] Fix race condition among serde tests

Posted by "sarutak (via GitHub)" <gi...@apache.org>.
sarutak commented on PR #2467:
URL: https://github.com/apache/avro/pull/2467#issuecomment-1700827924

   Thank you for the comment @martin-g !
   I agree that it's better to group related tests. 
   How about using `serial` attribute like `serial(avro_3747)` for such purpose rather than `file_serial`?
   https://docs.rs/serial_test/latest/serial_test/attr.serial.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] martin-g commented on pull request #2467: AVRO-3846: [Rust] Fix race condition among serde tests

Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #2467:
URL: https://github.com/apache/avro/pull/2467#issuecomment-1700854866

   Thank you, @sarutak !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org