You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/09/08 13:00:08 UTC

[GitHub] [couchdb] iilyak commented on pull request #3127: Prototype/fdb layer replace couch rate

iilyak commented on pull request #3127:
URL: https://github.com/apache/couchdb/pull/3127#issuecomment-688849471


   > I'm not convinced about having the default implementation of batch_module in the same file as couch_views_batch. I initially found it confusing trying to figure out where it starts and where couch_views_batch is. I would prefer we have a couch_batch module similar to couch_rate with the default module and couch_views_batch.
   
   I agree with Garren. This separation would also hide the `#batch_st{}` record in `couch_views_batch` module.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org