You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/08/08 08:22:05 UTC

[GitHub] [shardingsphere] jacksparrow414 opened a new pull request #6704: Issue#6594

jacksparrow414 opened a new pull request #6704:
URL: https://github.com/apache/shardingsphere/pull/6704


   Fixes #6594 .
   
   Changes proposed in this pull request:
   - add class named TypedSPIRegistryTest
   - add more test case for ShardingSphereServiceLoaderTest
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu merged pull request #6704: Fix issue#6594

Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #6704:
URL: https://github.com/apache/shardingsphere/pull/6704


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] jacksparrow414 removed a comment on pull request #6704: Fix issue#6594

Posted by GitBox <gi...@apache.org>.
jacksparrow414 removed a comment on pull request #6704:
URL: https://github.com/apache/shardingsphere/pull/6704#issuecomment-670892452


   > Please fix the ci
   
   This error may be caused by issue#6709.
    because org.apache.shardingsphere.infra.config.DataSourceConfigurationTest#assertAddAlias didn't pass.
    Do I need to resubmit an empty submission？


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] jacksparrow414 commented on pull request #6704: Fix issue#6594

Posted by GitBox <gi...@apache.org>.
jacksparrow414 commented on pull request #6704:
URL: https://github.com/apache/shardingsphere/pull/6704#issuecomment-670892452


   > Please fix the ci
   
   This error may be caused by issue#6709.
    because org.apache.shardingsphere.infra.config.DataSourceConfigurationTest#assertAddAlias didn't pass.
    Do I need to resubmit an empty submission？


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org