[GitHub] [metron] mmiklavc commented on a change in pull request #1523: METRON-2232 Upgrade to Hadoop 3.1.1

[GitBox <gi...@apache.org>]

mmiklavc commented on a change in pull request #1523: METRON-2232 Upgrade to Hadoop 3.1.1
URL: https://github.com/apache/metron/pull/1523#discussion_r339800915
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -148,6 +148,7 @@
                 <global_storm_kafka_version>1.2.3</global_storm_kafka_version>
                 <global_zeppelin_version>0.8.0</global_zeppelin_version>
                 <global_solr_version>7.4.0</global_solr_version>
+                <base_hadoop_version>3.1.1</base_hadoop_version>
 
 Review comment:
   > Actually, I think we can leave this as-is here. I was looking through this business of base and global versions and we have a few other things we need to clean-up here also prior to merging this into master. It probably makes sense to leave this as a follow-on PR.
   
   I had debated how we should handle this as well. I'd probably be ok with another final FB cleanup PR here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services