[GitHub] HeartSaVioR commented on issue #23706: [SPARK-26790][CORE] Change approach for retrieving executor logs and attributes: self-retrieve

[GitBox <gi...@apache.org>]

HeartSaVioR commented on issue #23706: [SPARK-26790][CORE] Change approach for retrieving executor logs and attributes: self-retrieve
URL: https://github.com/apache/spark/pull/23706#issuecomment-459887284
 
 
   @pgandhi999 
   Your understanding is right, but It has been possible for other resource managers to provide their own implementation, like what I did for YarnCoarseGrainedExecutorBackend. While I created base class for CoarseGrainedExecutorBackend, it only opens derived classes to override executor log url and attributes which will be effectively different on YARN and others. 
   
   So the intention of PR is honestly not target to broader scope. I just want to ensure `executor log url` and `attributes` are overridable.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org