You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "hainenber (via GitHub)" <gi...@apache.org> on 2025/02/13 07:14:24 UTC
[PR] build(fe/dev-deps): remove unused `esbuild` dev deps [superset]
hainenber opened a new pull request, #32243:
URL: https://github.com/apache/superset/pull/32243
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
build(fe/dev-deps): remove unused `esbuild` dev deps
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
I can't search for any `esbuild` reference in the codebase, even in the comments. `npm run build` also runs well after removal so it's pretty unused.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
N/A
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
All CI checks pass
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] build(fe/dev-deps): remove unused `esbuild` dev deps [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #32243:
URL: https://github.com/apache/superset/pull/32243#issuecomment-2657397993
This is fine, but I was actually wondering if we should be using it more. In some experiments, it looks like it might speed up webpack build times significantly. I'll keep experimenting, and can re-add it if it's relevant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] build(fe/dev-deps): remove unused `esbuild` dev deps [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber merged PR #32243:
URL: https://github.com/apache/superset/pull/32243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] build(fe/dev-deps): remove unused `esbuild` dev deps [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on PR #32243:
URL: https://github.com/apache/superset/pull/32243#issuecomment-2661248778
I'll be merging this with Evan's approval and with `esbuild` still in v0.x indicating it's not stable for production-ready. We'll revisit `esbuild` once it's ready to get the passing torch from `webpack`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] build(fe/dev-deps): remove unused `esbuild` dev deps [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on PR #32243:
URL: https://github.com/apache/superset/pull/32243#issuecomment-2658330624
My experience with `esbuild` is that it's good for greenfield projects and not so much for existing ones with sprawling Webpack config 🥲
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org