[GitHub] [dolphinscheduler] zhuangchong commented on a change in pull request #8139: [Feature-8138][Task] add at@ msg in the dingtalk task plugin

[GitBox <gi...@apache.org>]

zhuangchong commented on a change in pull request #8139:
URL: https://github.com/apache/dolphinscheduler/pull/8139#discussion_r789316207



##########
File path: dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-dingtalk/src/main/java/org/apache/dolphinscheduler/plugin/alert/dingtalk/DingTalkAlertChannelFactory.java
##########
@@ -64,6 +64,28 @@ public String name() {
                         .setRequired(false)
                         .build())
                 .build();
+        InputParam atMobilesParam = InputParam
+                .newBuilder(DingTalkParamsConstants.NAME_DING_TALK_AT_MOBILES, DingTalkParamsConstants.DING_TALK_AT_MOBILES)
+                .addValidate(Validate.newBuilder()
+                        .setRequired(false)
+                        .build())
+                .build();
+        InputParam atUserIdsParam = InputParam
+                .newBuilder(DingTalkParamsConstants.NAME_DING_TALK_AT_USERIDS, DingTalkParamsConstants.DING_TALK_AT_USERIDS)
+                .addValidate(Validate.newBuilder()
+                        .setRequired(false)
+                        .build())
+                .build();

Review comment:
       The document provided by the official website has this field
   ```
   https://open.dingtalk.com/document/robots/custom-robot-access
   ```
   I tested the mobile phone number, but I didn't find out what the userId of DingTalk is, so I didn't test the userId




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org