You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2016/12/01 06:45:23 UTC

Re: Review Request 54193: Refactored `Slave::Http::launchNestedContainer()`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54193/
-----------------------------------------------------------

(Updated Dec. 1, 2016, 6:45 a.m.)


Review request for mesos and Anand Mazumdar.


Changes
-------

updated for signature change. NNFR.


Summary (updated)
-----------------

Refactored `Slave::Http::launchNestedContainer()`.


Bugs: MESOS-6471
    https://issues.apache.org/jira/browse/MESOS-6471


Repository: mesos


Description
-------

This so that code can be reused for `launchNestedContainerSession()`
that will be added later. No functional change.


Diffs (updated)
-----

  src/slave/http.cpp 87189dd6e2e099cb74faabd3ad26aaca11e5cef2 
  src/slave/slave.hpp 05865a09724f7a46e9c06b02e59779513fc532aa 

Diff: https://reviews.apache.org/r/54193/diff/


Testing
-------

make check


Thanks,

Vinod Kone


Re: Review Request 54193: Refactored `Slave::Http::launchNestedContainer()`.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54193/
-----------------------------------------------------------

(Updated Dec. 2, 2016, 1 a.m.)


Review request for mesos and Anand Mazumdar.


Changes
-------

rebased. NNFR.


Bugs: MESOS-6471
    https://issues.apache.org/jira/browse/MESOS-6471


Repository: mesos


Description
-------

This so that code can be reused for `launchNestedContainerSession()`
that will be added later. No functional change.


Diffs (updated)
-----

  src/slave/http.cpp ace3575fd3a330f788e678283bc05e806cf9b264 
  src/slave/slave.hpp cfec9dd5fa3550ba1192fc86b1ff0d73ee1671e0 

Diff: https://reviews.apache.org/r/54193/diff/


Testing
-------

make check


Thanks,

Vinod Kone