[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #1363: refactor(conf): use DSN_DEFINE_bool to load bool type of configs

["acelyc111 (via GitHub)" <gi...@apache.org>]

acelyc111 commented on code in PR #1363:
URL: https://github.com/apache/incubator-pegasus/pull/1363#discussion_r1118386367


##########
src/utils/simple_logger.cpp:
##########
@@ -40,7 +40,6 @@ namespace dsn {
 namespace tools {
 
 DSN_DEFINE_bool(tools.simple_logger, fast_flush, false, "whether to flush immediately");
-
 DSN_DEFINE_bool(tools.simple_logger,
                 short_header,

Review Comment:
   It seems `screen_logger(const char *log_dir)` is only used in one test, and the parameter `log_dir` is useless, so I removed the c'stor and updated the only caller.
   
   ps: Two sections with one same key is not implemented yet.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org