You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/05 19:56:06 UTC
[GitHub] [doris] Yukang-LIAN commented on a diff in pull request #13056: [Feature](Retention) support retention function
Yukang-LIAN commented on code in PR #13056:
URL: https://github.com/apache/doris/pull/13056#discussion_r985264453
##########
be/src/exprs/aggregate_functions.h:
##########
@@ -372,6 +372,14 @@ class AggregateFunctions {
static StringVal window_funnel_serialize(FunctionContext* ctx, const StringVal& src);
static IntVal window_funnel_finalize(FunctionContext* ctx, const StringVal& src);
+ // retention
+ static void retention_init(FunctionContext* ctx, StringVal* dst);
+ static void retention_update(FunctionContext* ctx, int num_cond, const BooleanVal* conds,
+ StringVal* dst);
+ static void retention_merge(FunctionContext* ctx, const StringVal& src, StringVal* dst);
+ static StringVal retention_serialize(FunctionContext* ctx, const StringVal& src);
+ static BooleanVal* retention_finslize(FunctionContext* ctx, const StringVal& src);
+
// todo(kks): keep following HLL methods only for backward compatibility, we should remove these methods
Review Comment:
The retention function vectorization has been completed, and the test code will be completed soon.
##########
be/src/exprs/aggregate_functions.h:
##########
@@ -372,6 +372,14 @@ class AggregateFunctions {
static StringVal window_funnel_serialize(FunctionContext* ctx, const StringVal& src);
static IntVal window_funnel_finalize(FunctionContext* ctx, const StringVal& src);
+ // retention
+ static void retention_init(FunctionContext* ctx, StringVal* dst);
+ static void retention_update(FunctionContext* ctx, int num_cond, const BooleanVal* conds,
+ StringVal* dst);
+ static void retention_merge(FunctionContext* ctx, const StringVal& src, StringVal* dst);
+ static StringVal retention_serialize(FunctionContext* ctx, const StringVal& src);
+ static BooleanVal* retention_finslize(FunctionContext* ctx, const StringVal& src);
+
// todo(kks): keep following HLL methods only for backward compatibility, we should remove these methods
Review Comment:
The retention function vectorization has been completed, and the UT code will be completed soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org