You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by GitBox <gi...@apache.org> on 2021/06/14 07:25:38 UTC
[GitHub] [ranger] jles01 opened a new pull request #106: Support Java 11 and add trino plugin
jles01 opened a new pull request #106:
URL: https://github.com/apache/ranger/pull/106
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ranger] jles01 edited a comment on pull request #106: Support Java 11 and add trino plugin
Posted by GitBox <gi...@apache.org>.
jles01 edited a comment on pull request #106:
URL: https://github.com/apache/ranger/pull/106#issuecomment-896674819
> Hi, isn't the current `presto` plugin the one that should work for Trino as well? I understand after the Trino name change, there may need to be some package name changing, but for the most part there doesn't need to be any logical difference or use for the old "presto" plugin. Shouldn't we just rename everything in the Presto plugin and make it the official support for Trino?
From my knowledge presto still exists and will be continued. Should we move that users outside apache ranger ? I would not be so sure. We can have both or only Trino, the question would be how many "presto ranger" users out there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ranger] adnanhemani edited a comment on pull request #106: Support Java 11 and add trino plugin
Posted by GitBox <gi...@apache.org>.
adnanhemani edited a comment on pull request #106:
URL: https://github.com/apache/ranger/pull/106#issuecomment-896572718
Hi, isn't the current `presto` plugin the one that should work for Trino as well? I understand after the Trino name change, there may need to be some package name changing, but for the most part there doesn't need to be any logical difference or use for the old "presto" plugin. Shouldn't we just rename everything in the Presto plugin and make it the official support for Trino?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ranger] jerryleooo commented on pull request #106: Support Java 11 and add trino plugin
Posted by GitBox <gi...@apache.org>.
jerryleooo commented on pull request #106:
URL: https://github.com/apache/ranger/pull/106#issuecomment-938529644
Encountered following error
```
+ Fri Oct 8 18:21:12 +08 2021 : Saving lib file: /opt/presto/lib/validation-api-2.0.1.Final.jar to /opt/presto/lib/.validation-api-2.0.1.Final.jar.20211008182112 ...
Unable to store password in non-plain text format. Error: [SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
Exception in thread "main" java.lang.NoClassDefFoundError: org/apache/commons/lang3/StringUtils
at org.apache.hadoop.metrics2.lib.MutableMetricsFactory.getName(MutableMetricsFactory.java:134)
at org.apache.hadoop.metrics2.lib.MutableMetricsFactory.getInfo(MutableMetricsFactory.java:130)
at org.apache.hadoop.metrics2.lib.MutableMetricsFactory.newForField(MutableMetricsFactory.java:45)
at org.apache.hadoop.metrics2.lib.MetricsSourceBuilder.add(MetricsSourceBuilder.java:147)
at org.apache.hadoop.metrics2.lib.MetricsSourceBuilder.<init>(MetricsSourceBuilder.java:69)
at org.apache.hadoop.metrics2.lib.MetricsAnnotations.newSourceBuilder(MetricsAnnotations.java:43)
at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.register(MetricsSystemImpl.java:223)
at org.apache.hadoop.metrics2.MetricsSystem.register(MetricsSystem.java:71)
at org.apache.hadoop.security.UserGroupInformation$UgiMetrics.create(UserGroupInformation.java:149)
at org.apache.hadoop.security.UserGroupInformation.<clinit>(UserGroupInformation.java:265)
at org.apache.hadoop.fs.FileSystem$Cache$Key.<init>(FileSystem.java:3614)
at org.apache.hadoop.fs.FileSystem$Cache$Key.<init>(FileSystem.java:3604)
at org.apache.hadoop.fs.FileSystem$Cache.get(FileSystem.java:3441)
at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:524)
at org.apache.hadoop.fs.Path.getFileSystem(Path.java:365)
at org.apache.hadoop.security.alias.JavaKeyStoreProvider.initFileSystem(JavaKeyStoreProvider.java:89)
at org.apache.hadoop.security.alias.AbstractJavaKeyStoreProvider.<init>(AbstractJavaKeyStoreProvider.java:85)
at org.apache.hadoop.security.alias.JavaKeyStoreProvider.<init>(JavaKeyStoreProvider.java:49)
at org.apache.hadoop.security.alias.JavaKeyStoreProvider.<init>(JavaKeyStoreProvider.java:41)
at org.apache.hadoop.security.alias.JavaKeyStoreProvider$Factory.createProvider(JavaKeyStoreProvider.java:100)
at org.apache.hadoop.security.alias.CredentialProviderFactory.getProviders(CredentialProviderFactory.java:73)
at org.apache.ranger.credentialapi.CredentialReader.getDecryptedString(CredentialReader.java:74)
at org.apache.ranger.credentialapi.buildks.createCredential(buildks.java:87)
at org.apache.ranger.credentialapi.buildks.main(buildks.java:41)
Caused by: java.lang.ClassNotFoundException: org.apache.commons.lang3.StringUtils
at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:606)
at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:168)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:522)
... 24 more]
Exiting plugin installation
```
Java version: 15.0.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [GitHub] [ranger] jles01 commented on pull request #106: Support
Java 11 and add trino plugin
Posted by Ricardo Martinelli de Oliveira <rm...@redhat.com>.
Trino is just the new name after PrestoSQL, but there is also PrestoDB (the
enterprise offering from Starburst). Having that said, Presto plugin should
be still available.
On Thu, Aug 12, 2021 at 7:15 AM GitBox <gi...@apache.org> wrote:
>
> jles01 commented on pull request #106:
> URL: https://github.com/apache/ranger/pull/106#issuecomment-897513662
>
>
> Ok so the new plugin is all set up :) the question should I remove the
> presto one or not ...
>
>
> --
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org
>
> For queries about this service, please contact Infrastructure at:
> users@infra.apache.org
>
>
>
--
Ricardo Martinelli De Oliveira
Senior Software Engineer, AI CoE
Red Hat Brazil <https://www.redhat.com/>
Av. Brigadeiro Faria Lima, 3900
8th floor
rmartine@redhat.com T: +551135426125
M: +5511970696531
@redhatjobs <https://twitter.com/redhatjobs> redhatjobs
<https://www.facebook.com/redhatjobs> @redhatjobs
<https://instagram.com/redhatjobs>
<https://www.redhat.com/>
[GitHub] [ranger] jles01 commented on pull request #106: Support Java 11 and add trino plugin
Posted by GitBox <gi...@apache.org>.
jles01 commented on pull request #106:
URL: https://github.com/apache/ranger/pull/106#issuecomment-897513662
Ok so the new plugin is all set up :) the question should I remove the presto one or not ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ranger] adnanhemani commented on pull request #106: Support Java 11 and add trino plugin
Posted by GitBox <gi...@apache.org>.
adnanhemani commented on pull request #106:
URL: https://github.com/apache/ranger/pull/106#issuecomment-896572718
Hi, isn't the current `presto` plugin the one that should work for Trino as well? I understand after the Trino fork, there may need to be some package name changing, but for the most part there doesn't need to be any logical difference or use for the old "presto" plugin. Shouldn't we just rename everything in the Presto plugin and make it the official support for Trino?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ranger] adnanhemani commented on pull request #106: Support Java 11 and add trino plugin
Posted by GitBox <gi...@apache.org>.
adnanhemani commented on pull request #106:
URL: https://github.com/apache/ranger/pull/106#issuecomment-898045343
I think we can keep it for now 🤷 we can remove in a later PR, if required?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ranger] adnanhemani edited a comment on pull request #106: Support Java 11 and add trino plugin
Posted by GitBox <gi...@apache.org>.
adnanhemani edited a comment on pull request #106:
URL: https://github.com/apache/ranger/pull/106#issuecomment-897142049
Actually, I just read this thread: [here](https://issues.apache.org/jira/browse/RANGER-3182?focusedCommentId=17311823&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17311823). Seems like a new Trino plugin will be required - but not as a result of the issues we were discussing 😁
Watching thread for progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ranger] adnanhemani edited a comment on pull request #106: Support Java 11 and add trino plugin
Posted by GitBox <gi...@apache.org>.
adnanhemani edited a comment on pull request #106:
URL: https://github.com/apache/ranger/pull/106#issuecomment-897142049
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ranger] martin-g commented on a change in pull request #106: Support Java 11 and add trino plugin
Posted by GitBox <gi...@apache.org>.
martin-g commented on a change in pull request #106:
URL: https://github.com/apache/ranger/pull/106#discussion_r713410698
##########
File path: kms/src/main/java/org/apache/hadoop/crypto/key/RangerSafenetKeySecure.java
##########
@@ -68,9 +68,9 @@ public RangerSafenetKeySecure(Configuration conf) throws Exception {
try {
int javaVersion = getJavaVersion();
/*Minimum java requirement for Ranger KMS is Java 8 and Maximum java supported by Ranger KMS is Java 11*/
- if(javaVersion == 8){
+ /*if(javaVersion == 8){
provider = new sun.security.pkcs11.SunPKCS11(pkcs11CfgFilePath);
- }else if(javaVersion == 9 || javaVersion == 10 || javaVersion == 11){
+ }else*/ if(javaVersion == 9 || javaVersion == 10 || javaVersion == 11){
Review comment:
See https://github.com/apache/ranger/pull/96 for better solution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ranger] adnanhemani commented on pull request #106: Support Java 11 and add trino plugin
Posted by GitBox <gi...@apache.org>.
adnanhemani commented on pull request #106:
URL: https://github.com/apache/ranger/pull/106#issuecomment-897132478
From what I gathered, it seemed like PrestoDB was _not_ supported by our current presto plugin and that a new PrestoDB plugin would be required that would have slightly different logic. If that's correct, I'd think that it makes more sense to say the current Ranger version (v2.1.0) is the latest version supported for all Trino versions before the renaming and the next Ranger version will have support for all Trino versions past the Trino renaming - and that we should change the current presto plugin to be the official Trino plugin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ranger] jles01 commented on pull request #106: Support Java 11 and add trino plugin
Posted by GitBox <gi...@apache.org>.
jles01 commented on pull request #106:
URL: https://github.com/apache/ranger/pull/106#issuecomment-896674819
> Hi, isn't the current `presto` plugin the one that should work for Trino as well? I understand after the Trino name change, there may need to be some package name changing, but for the most part there doesn't need to be any logical difference or use for the old "presto" plugin. Shouldn't we just rename everything in the Presto plugin and make it the official support for Trino?
From my knowledge presto still exists and will be continued. Should we move that users outside apache ranger ? I would not be so sure. We can have both or only Trino, the question would be how much "presto ranger" users out there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ranger] adnanhemani commented on pull request #106: Support Java 11 and add trino plugin
Posted by GitBox <gi...@apache.org>.
adnanhemani commented on pull request #106:
URL: https://github.com/apache/ranger/pull/106#issuecomment-897142049
Actually, I just read this thread: [](hhttps://issues.apache.org/jira/browse/RANGER-3182?focusedCommentId=17311823&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17311823). Seems like a new Trino plugin will be required - but not for the issues we were discussing 😁
Watching thread for progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ranger] jles01 commented on pull request #106: Support Java 11 and add trino plugin
Posted by GitBox <gi...@apache.org>.
jles01 commented on pull request #106:
URL: https://github.com/apache/ranger/pull/106#issuecomment-891698025
Hi,
It is working, there will be minor changes, to make it build with success. Also in other PR there will be added Trino support for Hive security, so they can be reused
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ranger] exolab commented on pull request #106: Support Java 11 and add trino plugin
Posted by GitBox <gi...@apache.org>.
exolab commented on pull request #106:
URL: https://github.com/apache/ranger/pull/106#issuecomment-890580847
Is this still being worked on?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org