You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "jihuayu (via GitHub)" <gi...@apache.org> on 2023/12/16 02:05:21 UTC

[D] Has BloomFilter and Json type key supported slot migrations [kvrocks]

GitHub user jihuayu created a discussion: Has BloomFilter and Json type key supported slot migrations

When I was reading the code in [slot_migrate.cc](https://github.com/jihuayu/incubator-kvrocks/blob/5e60dc255dde6da3ef4aa9913acfb9741b38fbb4/src/cluster/slot_migrate.cc), I noticed that slot migration seems to be not working for the new types `kRedisBloomFilter` and `kRedisJson`. 

I wanted to ask if my understanding is incorrect. What happens now when slot migration involves these two types?


**Something related:**
- https://github.com/apache/kvrocks/issues/1805
- https://github.com/apache/kvrocks/issues/1696


GitHub link: https://github.com/apache/kvrocks/discussions/1934

----
This is an automatically sent email for issues@kvrocks.apache.org.
To unsubscribe, please send an email to: issues-unsubscribe@kvrocks.apache.org


Re: [D] Has BloomFilter and Json type key supported slot migrations [kvrocks]

Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
GitHub user git-hulk added a comment to the discussion: Has BloomFilter and Json type key supported slot migrations

@jihuayu Yes, you're right. I'm thinking about how to make those migration codes easier to maintain. It's too hard for contributors to take care of this when adding the new command.

GitHub link: https://github.com/apache/kvrocks/discussions/1934#discussioncomment-7869105

----
This is an automatically sent email for issues@kvrocks.apache.org.
To unsubscribe, please send an email to: issues-unsubscribe@kvrocks.apache.org