You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by br...@apache.org on 2012/11/29 16:31:27 UTC
svn commit: r1415212 - /subversion/trunk/subversion/svn/list-cmd.c
Author: breser
Date: Thu Nov 29 15:31:27 2012
New Revision: 1415212
URL: http://svn.apache.org/viewvc?rev=1415212&view=rev
Log:
Remove some unnecessary code duplication.
* subversion/svn/list-cmd.c
(svn_cl__list): Remove the error composition from the if/else block both
paths use it.
Modified:
subversion/trunk/subversion/svn/list-cmd.c
Modified: subversion/trunk/subversion/svn/list-cmd.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/svn/list-cmd.c?rev=1415212&r1=1415211&r2=1415212&view=diff
==============================================================================
--- subversion/trunk/subversion/svn/list-cmd.c (original)
+++ subversion/trunk/subversion/svn/list-cmd.c Thu Nov 29 15:31:27 2012
@@ -416,11 +416,8 @@ svn_cl__list(apr_getopt_t *os,
SVN_ERR(svn_cl__xml_print_footer("lists", pool));
if (seen_nonexistent_target)
- {
- err = svn_error_create(SVN_ERR_ILLEGAL_TARGET, NULL,
- _("Could not list all targets because some targets don't exist"));
- return svn_error_compose_create(externals_err, err);
- }
- else
- return svn_error_compose_create(externals_err, err);
+ err = svn_error_create(SVN_ERR_ILLEGAL_TARGET, NULL,
+ _("Could not list all targets because some targets don't exist"));
+
+ return svn_error_compose_create(externals_err, err);
}