You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sling.apache.org by "Carsten Ziegeler (JIRA)" <ji...@apache.org> on 2017/08/11 13:38:00 UTC

[jira] [Comment Edited] (SLING-7043) Exporting com.codahale.metrics.MetricRegistry is breaking the abstraction

    [ https://issues.apache.org/jira/browse/SLING-7043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123346#comment-16123346 ] 

Carsten Ziegeler edited comment on SLING-7043 at 8/11/17 1:37 PM:
------------------------------------------------------------------

Why do we have sling commons metrics at all?


was (Author: cziegeler):
Why do we have the then sling commons metrics at all?

> Exporting  com.codahale.metrics.MetricRegistry is breaking the abstraction
> --------------------------------------------------------------------------
>
>                 Key: SLING-7043
>                 URL: https://issues.apache.org/jira/browse/SLING-7043
>             Project: Sling
>          Issue Type: Bug
>    Affects Versions: Commons Metrics 1.0.0
>            Reporter: Carsten Ziegeler
>            Priority: Blocker
>             Fix For: commons metrics 1.2.4
>
>
> commons metrics provides a nice abstraction over  com.codahale.metrics - however it is exporting  com.codahale.metrics.MetricRegistry which seems to be the only way to get at registered metrics objects. Which in turn is completely breaking the purpose of this bundle.
> So we should
> a) drop exporting that service and avoid leaking internal implementation details
> b) create our own version of the registry service



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)