You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/10 03:14:53 UTC
[GitHub] [incubator-doris] eldenmoon opened a new issue, #10051: [Enhancement] SimdJson enable -o3
eldenmoon opened a new issue, #10051:
URL: https://github.com/apache/incubator-doris/issues/10051
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues.
### Description
build_simdjson with wrong compile flags
```
build_simdjson() {
check_if_source_exist $SIMDJSON_SOURCE
cd $TP_SOURCE_DIR/$SIMDJSON_SOURCE
mkdir -p $BUILD_DIR && cd $BUILD_DIR
CXX_FLAGS="-O3" \
C_FLAGS="-O3" \
$CMAKE_CMD ..
$CMAKE_CMD --build .
cp $TP_SOURCE_DIR/$SIMDJSON_SOURCE/$BUILD_DIR/libsimdjson.a $TP_INSTALL_DIR/lib64
cp -r $TP_SOURCE_DIR/$SIMDJSON_SOURCE/include/* $TP_INCLUDE_DIR/
}
```
**CXX_FLAGS should be CXXFLAGS and C_FLAGS should be CFLAGS** otherwise the compile flags are not enabled
### Solution
**CXX_FLAGS should be CXXFLAGS and C_FLAGS should be CFLAGS** otherwise the compile flags are not enabled
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yiguolei closed issue #10051: [Enhancement] simdJson compile should enable -O3
Posted by GitBox <gi...@apache.org>.
yiguolei closed issue #10051: [Enhancement] simdJson compile should enable -O3
URL: https://github.com/apache/incubator-doris/issues/10051
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org