[GitHub] [cordova-android] AndreyZM opened a new pull request #894: (android) Additional WebView preferences: 'UseWideViewport', 'SaveFormData', 'SavePassword'

[GitBox <gi...@apache.org>]

AndreyZM opened a new pull request #894: (android) Additional WebView preferences: 'UseWideViewport', 'SaveFormData', 'SavePassword'
URL: https://github.com/apache/cordova-android/pull/894
 
 
   ### Platforms affected
   android
   
   
   ### Motivation and Context
   Now its not possible to set some useful android WebView settings such UseWideViewport, that give a developer define meta viewport tag in cordova apps. Also 'SaveFormData' & 'SavePassword' give more browser like user experience.
   
   
   
   ### Description
   Values for WebView settings are loads from config.xml preferences: 
   - UseWideViewport 
   - SaveFormData 
   - SavePassword
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [x] I added automated test coverage as appropriate for this change
   - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [x] I've updated the documentation if necessary
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org

[GitHub] [cordova-android] dpogue commented on issue #894: (android) Additional WebView preferences: 'UseWideViewport', 'SaveFormData', 'SavePassword'

[GitBox <gi...@apache.org>]

dpogue commented on issue #894: (android) Additional WebView preferences: 'UseWideViewport', 'SaveFormData', 'SavePassword'
URL: https://github.com/apache/cordova-android/pull/894#issuecomment-586661693
 
 
   `setSaveFormData` and `setSavePassword` are deprecated methods, so the best thing to do is probably to remove them from the code entirely. The behaviour of saving (or not) can be managed by the app author on a more specific level using HTML attributes.
   
   I think we always want `setUseWideViewPort(true)` so that it obeys the viewport as specified by the app author.
   
   As much as possible, we should allow things to be controlled by the app author via their HTML as opposed to via config preferences.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org