[GitHub] [spark] ulysses-you commented on a diff in pull request #37831: [SPARK-40354][SQL] Support eliminate dynamic partition for datasource v1 writes

[GitBox <gi...@apache.org>]

ulysses-you commented on code in PR #37831:
URL: https://github.com/apache/spark/pull/37831#discussion_r966612740


##########
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala:
##########
@@ -1539,7 +1539,7 @@ abstract class DDLSuite extends QueryTest with DDLSuiteBase {
           assert(table.location == makeQualifiedPath(dir.getAbsolutePath))
           assert(spark.sql(s"SHOW PARTITIONS $tableName").count() == 0)
           spark.sql(
-            s"INSERT INTO TABLE $tableName PARTITION(c='c', b) SELECT *, 'b' FROM t WHERE 1 = 0")
+            s"INSERT INTO TABLE $tableName PARTITION(c='c', b) SELECT *, a FROM t WHERE 1 = 0")

Review Comment:
   this test is used to validate partial static partition, so use a column instead of literal to recover it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org