You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by pu...@apache.org on 2015/07/28 19:37:32 UTC
[1/2] cordova-lib git commit: CB-9405 limit author/description to 256
char per WMAppManifest schema
Repository: cordova-lib
Updated Branches:
refs/heads/master 525a4b9a9 -> b11d0f00b
CB-9405 limit author/description to 256 char per WMAppManifest schema
Project: http://git-wip-us.apache.org/repos/asf/cordova-lib/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-lib/commit/10a48e3d
Tree: http://git-wip-us.apache.org/repos/asf/cordova-lib/tree/10a48e3d
Diff: http://git-wip-us.apache.org/repos/asf/cordova-lib/diff/10a48e3d
Branch: refs/heads/master
Commit: 10a48e3d04450413e16b287f2b756ec953e06cc0
Parents: 02ae8a2
Author: Jesse MacFadyen <pu...@gmail.com>
Authored: Thu Jul 23 15:58:37 2015 -0700
Committer: Jesse MacFadyen <pu...@gmail.com>
Committed: Thu Jul 23 15:58:37 2015 -0700
----------------------------------------------------------------------
cordova-lib/src/cordova/metadata/wp8_parser.js | 16 ++++++++++++++--
1 file changed, 14 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-lib/blob/10a48e3d/cordova-lib/src/cordova/metadata/wp8_parser.js
----------------------------------------------------------------------
diff --git a/cordova-lib/src/cordova/metadata/wp8_parser.js b/cordova-lib/src/cordova/metadata/wp8_parser.js
index 0649ba9..557c1b7 100644
--- a/cordova-lib/src/cordova/metadata/wp8_parser.js
+++ b/cordova-lib/src/cordova/metadata/wp8_parser.js
@@ -106,8 +106,20 @@ wp8_parser.prototype.update_from_config = function(config) {
}
// Update author, publisher and description
- var author = config.author() || '',
- description = config.description() || '';
+ // limit both to 256 char including spaces
+ var author = config.author() || '';
+ var description = config.description() || '';
+
+ if(author.length > 256) {
+ events.emit('warn','Author length from config.xml is too long. Truncating to 256 char');
+ author = author.substr(0,256);
+ }
+
+ if(description.length > 256) {
+ events.emit('warn','Description length from config.xml is too long. Truncating to 256 char');
+ description = author.substr(0,256);
+ }
+
manifest.find('.//App').attrib.Author = author;
manifest.find('.//App').attrib.Publisher = author;
manifest.find('.//App').attrib.Description = description;
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[2/2] cordova-lib git commit: Merge branch 'CB-9405' of
github.com:purplecabbage/cordova-lib
Posted by pu...@apache.org.
Merge branch 'CB-9405' of github.com:purplecabbage/cordova-lib
Project: http://git-wip-us.apache.org/repos/asf/cordova-lib/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-lib/commit/b11d0f00
Tree: http://git-wip-us.apache.org/repos/asf/cordova-lib/tree/b11d0f00
Diff: http://git-wip-us.apache.org/repos/asf/cordova-lib/diff/b11d0f00
Branch: refs/heads/master
Commit: b11d0f00b0aad05d13b19814088b460771b1193d
Parents: 525a4b9 10a48e3
Author: Jesse MacFadyen <pu...@gmail.com>
Authored: Tue Jul 28 10:37:15 2015 -0700
Committer: Jesse MacFadyen <pu...@gmail.com>
Committed: Tue Jul 28 10:37:15 2015 -0700
----------------------------------------------------------------------
cordova-lib/src/cordova/metadata/wp8_parser.js | 16 ++++++++++++++--
1 file changed, 14 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org