You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by "Leif Hedstrom (JIRA)" <ji...@apache.org> on 2009/11/03 19:37:32 UTC
[jira] Created: (TS-9) InkAPI.h and RemapPlugin.h are missing from
/usr/local/include
InkAPI.h and RemapPlugin.h are missing from /usr/local/include
---------------------------------------------------------------
Key: TS-9
URL: https://issues.apache.org/jira/browse/TS-9
Project: Traffic Server
Issue Type: Bug
Components: Build
Reporter: Leif Hedstrom
I think we need to "install" ("gmake install") these two files into $PREFIX/include. This is to make building plugins easier.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TS-9) InkAPI.h and RemapPlugin.h are missing from
/usr/local/include
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-9?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom updated TS-9:
---------------------------
Attachment: TS-9-Remap_h.patch
This is the patch for renaming RemapAPI.h to api/include/remap.h. Note that this diff does not show the required SVN command:
svn move proxy/RemapAPI.h proxy/api/include/remap.h
> InkAPI.h and RemapPlugin.h are missing from /usr/local/include
> ---------------------------------------------------------------
>
> Key: TS-9
> URL: https://issues.apache.org/jira/browse/TS-9
> Project: Traffic Server
> Issue Type: Bug
> Components: Build
> Reporter: Leif Hedstrom
> Assignee: Leif Hedstrom
> Fix For: 2.0.0a
>
> Attachments: TS-9-InkAPI-h.patch, TS-9-Remap_h.patch
>
>
> I think we need to "install" ("gmake install") these two files into $PREFIX/include. This is to make building plugins easier.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Work started: (TS-9) InkAPI.h and RemapPlugin.h are missing
from /usr/local/include
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-9?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on TS-9 started by Leif Hedstrom.
> InkAPI.h and RemapPlugin.h are missing from /usr/local/include
> ---------------------------------------------------------------
>
> Key: TS-9
> URL: https://issues.apache.org/jira/browse/TS-9
> Project: Traffic Server
> Issue Type: Bug
> Components: Build
> Reporter: Leif Hedstrom
> Assignee: Leif Hedstrom
> Fix For: 2.0.0a
>
>
> I think we need to "install" ("gmake install") these two files into $PREFIX/include. This is to make building plugins easier.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TS-9) InkAPI.h and RemapPlugin.h are missing
from /usr/local/include
Posted by "George Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835278#action_12835278 ]
George Paul commented on TS-9:
------------------------------
The ' TS-9-Remap_h.patch' patch looks fine. Reviewed and tested.
-George
> InkAPI.h and RemapPlugin.h are missing from /usr/local/include
> ---------------------------------------------------------------
>
> Key: TS-9
> URL: https://issues.apache.org/jira/browse/TS-9
> Project: Traffic Server
> Issue Type: Bug
> Components: Build
> Reporter: Leif Hedstrom
> Assignee: Leif Hedstrom
> Fix For: 2.0.0a
>
> Attachments: TS-9-InkAPI-h.patch, TS-9-Remap_h.patch
>
>
> I think we need to "install" ("gmake install") these two files into $PREFIX/include. This is to make building plugins easier.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (TS-9) InkAPI.h and RemapPlugin.h are missing
from /usr/local/include
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-9?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom resolved TS-9.
----------------------------
Resolution: Fixed
> InkAPI.h and RemapPlugin.h are missing from /usr/local/include
> ---------------------------------------------------------------
>
> Key: TS-9
> URL: https://issues.apache.org/jira/browse/TS-9
> Project: Traffic Server
> Issue Type: Bug
> Components: Build
> Reporter: Leif Hedstrom
> Assignee: Leif Hedstrom
> Fix For: 2.0.0a
>
> Attachments: TS-9-InkAPI-h.patch, TS-9-Makefile.patch, TS-9-Private_h.patch, TS-9-Remap_h.patch
>
>
> I think we need to "install" ("gmake install") these two files into $PREFIX/include. This is to make building plugins easier.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TS-9) InkAPI.h and RemapPlugin.h are missing
from /usr/local/include
Posted by "George Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835530#action_12835530 ]
George Paul commented on TS-9:
------------------------------
Changes look fine. After applying the patch I had to edit the moved/copied over 'InkAPIPrivate.h' -> 'ts_private.h' and change "InkAPIPrivateFrozen.h" -> 'ts_private_frozen.h". Reviewed and tested.
-George
> InkAPI.h and RemapPlugin.h are missing from /usr/local/include
> ---------------------------------------------------------------
>
> Key: TS-9
> URL: https://issues.apache.org/jira/browse/TS-9
> Project: Traffic Server
> Issue Type: Bug
> Components: Build
> Reporter: Leif Hedstrom
> Assignee: Leif Hedstrom
> Fix For: 2.0.0a
>
> Attachments: TS-9-InkAPI-h.patch, TS-9-Private_h.patch, TS-9-Remap_h.patch
>
>
> I think we need to "install" ("gmake install") these two files into $PREFIX/include. This is to make building plugins easier.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TS-9) InkAPI.h and RemapPlugin.h are missing from
/usr/local/include
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-9?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom updated TS-9:
---------------------------
Fix Version/s: 2.0.0
> InkAPI.h and RemapPlugin.h are missing from /usr/local/include
> ---------------------------------------------------------------
>
> Key: TS-9
> URL: https://issues.apache.org/jira/browse/TS-9
> Project: Traffic Server
> Issue Type: Bug
> Components: Build
> Reporter: Leif Hedstrom
> Assignee: Andrew Hsu
> Fix For: 2.0.0
>
>
> I think we need to "install" ("gmake install") these two files into $PREFIX/include. This is to make building plugins easier.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TS-9) InkAPI.h and RemapPlugin.h are missing from
/usr/local/include
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-9?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom updated TS-9:
---------------------------
Attachment: TS-9-Makefile.patch
This is the last "patch" for this change, this will install the include files in ${prefix}/include/ts.
Please review.
> InkAPI.h and RemapPlugin.h are missing from /usr/local/include
> ---------------------------------------------------------------
>
> Key: TS-9
> URL: https://issues.apache.org/jira/browse/TS-9
> Project: Traffic Server
> Issue Type: Bug
> Components: Build
> Reporter: Leif Hedstrom
> Assignee: Leif Hedstrom
> Fix For: 2.0.0a
>
> Attachments: TS-9-InkAPI-h.patch, TS-9-Makefile.patch, TS-9-Private_h.patch, TS-9-Remap_h.patch
>
>
> I think we need to "install" ("gmake install") these two files into $PREFIX/include. This is to make building plugins easier.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TS-9) InkAPI.h and RemapPlugin.h are missing
from /usr/local/include
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778412#action_12778412 ]
Leif Hedstrom commented on TS-9:
--------------------------------
Ok, so /usr/local/include/trafficserver ? Maybe we should consider renaming the other dirs to something shorter? /Maybe .../var/log/ts and .../etc/ts/ ? Or maybe .../include/ats, .../var/log/ats and .../etc/ats ? ( I think I like ats better, to avoid potential conflicts ("traffiserver" is tediously long, but I don't feel particularly strongly either way, other than making sure we don't pollute the "top" include dir).
As for versioning, I assume the purpose is not generally to allow multiple installations, but to assure that when we break compatibility (hopefully very rarely) plugins will fail to compile and force plugin authors to "fix" their plugins. Hence, we would only use "major" versioning in these dir names ?
> InkAPI.h and RemapPlugin.h are missing from /usr/local/include
> ---------------------------------------------------------------
>
> Key: TS-9
> URL: https://issues.apache.org/jira/browse/TS-9
> Project: Traffic Server
> Issue Type: Bug
> Components: Build
> Reporter: Leif Hedstrom
> Assignee: Andrew Hsu
>
> I think we need to "install" ("gmake install") these two files into $PREFIX/include. This is to make building plugins easier.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TS-9) InkAPI.h and RemapPlugin.h are missing
from /usr/local/include
Posted by "Bryan Call (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778402#action_12778402 ]
Bryan Call commented on TS-9:
-----------------------------
There should be only one consistent name for naming Traffic Server directories. Currently we are using trafficserver (../etc/trafficserver, ../var/log/trafficserver, ../var/trafficserver)
The include directory should follow the same standard.
I see some packages use major and minor versions numbers when creating include directories. What is the benefit of having a different directory path per version? I don't see it useful to allow multiple versions of the headers installed at the same time.
> InkAPI.h and RemapPlugin.h are missing from /usr/local/include
> ---------------------------------------------------------------
>
> Key: TS-9
> URL: https://issues.apache.org/jira/browse/TS-9
> Project: Traffic Server
> Issue Type: Bug
> Components: Build
> Reporter: Leif Hedstrom
> Assignee: Andrew Hsu
>
> I think we need to "install" ("gmake install") these two files into $PREFIX/include. This is to make building plugins easier.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TS-9) InkAPI.h and RemapPlugin.h are missing
from /usr/local/include
Posted by "George Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835094#action_12835094 ]
George Paul commented on TS-9:
------------------------------
Apply the patch seems to not delete the old 'InkAPI.h' and create the new 'ts.h'. Other than that it looks fine after changing 'InkAPI.h' -> 'ts.h' and fixing it's header #define
-George
> InkAPI.h and RemapPlugin.h are missing from /usr/local/include
> ---------------------------------------------------------------
>
> Key: TS-9
> URL: https://issues.apache.org/jira/browse/TS-9
> Project: Traffic Server
> Issue Type: Bug
> Components: Build
> Reporter: Leif Hedstrom
> Assignee: Leif Hedstrom
> Fix For: 2.0.0a
>
> Attachments: TS-9-InkAPI-h.patch
>
>
> I think we need to "install" ("gmake install") these two files into $PREFIX/include. This is to make building plugins easier.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TS-9) InkAPI.h and RemapPlugin.h are missing from
/usr/local/include
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-9?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom updated TS-9:
---------------------------
Fix Version/s: (was: 2.0.0)
2.0.0a
> InkAPI.h and RemapPlugin.h are missing from /usr/local/include
> ---------------------------------------------------------------
>
> Key: TS-9
> URL: https://issues.apache.org/jira/browse/TS-9
> Project: Traffic Server
> Issue Type: Bug
> Components: Build
> Reporter: Leif Hedstrom
> Assignee: Andrew Hsu
> Fix For: 2.0.0a
>
>
> I think we need to "install" ("gmake install") these two files into $PREFIX/include. This is to make building plugins easier.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Work stopped: (TS-9) InkAPI.h and RemapPlugin.h are missing
from /usr/local/include
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-9?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on TS-9 stopped by Leif Hedstrom.
> InkAPI.h and RemapPlugin.h are missing from /usr/local/include
> ---------------------------------------------------------------
>
> Key: TS-9
> URL: https://issues.apache.org/jira/browse/TS-9
> Project: Traffic Server
> Issue Type: Bug
> Components: Build
> Reporter: Leif Hedstrom
> Assignee: Leif Hedstrom
> Fix For: 2.0.0a
>
> Attachments: TS-9-InkAPI-h.patch, TS-9-Makefile.patch, TS-9-Private_h.patch, TS-9-Remap_h.patch
>
>
> I think we need to "install" ("gmake install") these two files into $PREFIX/include. This is to make building plugins easier.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TS-9) InkAPI.h and RemapPlugin.h are missing
from /usr/local/include
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-9?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom reassigned TS-9:
------------------------------
Assignee: Leif Hedstrom (was: Andrew Hsu)
> InkAPI.h and RemapPlugin.h are missing from /usr/local/include
> ---------------------------------------------------------------
>
> Key: TS-9
> URL: https://issues.apache.org/jira/browse/TS-9
> Project: Traffic Server
> Issue Type: Bug
> Components: Build
> Reporter: Leif Hedstrom
> Assignee: Leif Hedstrom
> Fix For: 2.0.0a
>
>
> I think we need to "install" ("gmake install") these two files into $PREFIX/include. This is to make building plugins easier.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TS-9) InkAPI.h and RemapPlugin.h are missing
from /usr/local/include
Posted by "Paul Querna (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778207#action_12778207 ]
Paul Querna commented on TS-9:
------------------------------
+1, though APR/httpd does include its major version number in the paths.
So, it would be:
ts-0/api.h
is that helpful for ts? not as sure.
> InkAPI.h and RemapPlugin.h are missing from /usr/local/include
> ---------------------------------------------------------------
>
> Key: TS-9
> URL: https://issues.apache.org/jira/browse/TS-9
> Project: Traffic Server
> Issue Type: Bug
> Components: Build
> Reporter: Leif Hedstrom
> Assignee: Andrew Hsu
>
> I think we need to "install" ("gmake install") these two files into $PREFIX/include. This is to make building plugins easier.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TS-9) InkAPI.h and RemapPlugin.h are missing from
/usr/local/include
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-9?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom updated TS-9:
---------------------------
Attachment: TS-9-InkAPI-h.patch
First phase of this massive change, renaming InkAPI.h to ts.h.
Could someone please review?
> InkAPI.h and RemapPlugin.h are missing from /usr/local/include
> ---------------------------------------------------------------
>
> Key: TS-9
> URL: https://issues.apache.org/jira/browse/TS-9
> Project: Traffic Server
> Issue Type: Bug
> Components: Build
> Reporter: Leif Hedstrom
> Assignee: Leif Hedstrom
> Fix For: 2.0.0a
>
> Attachments: TS-9-InkAPI-h.patch
>
>
> I think we need to "install" ("gmake install") these two files into $PREFIX/include. This is to make building plugins easier.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TS-9) InkAPI.h and RemapPlugin.h are missing
from /usr/local/include
Posted by "George Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835573#action_12835573 ]
George Paul commented on TS-9:
------------------------------
Patch 'TS-9-Makefile.patch' looks fine. Reviewed and tested.
-George
> InkAPI.h and RemapPlugin.h are missing from /usr/local/include
> ---------------------------------------------------------------
>
> Key: TS-9
> URL: https://issues.apache.org/jira/browse/TS-9
> Project: Traffic Server
> Issue Type: Bug
> Components: Build
> Reporter: Leif Hedstrom
> Assignee: Leif Hedstrom
> Fix For: 2.0.0a
>
> Attachments: TS-9-InkAPI-h.patch, TS-9-Makefile.patch, TS-9-Private_h.patch, TS-9-Remap_h.patch
>
>
> I think we need to "install" ("gmake install") these two files into $PREFIX/include. This is to make building plugins easier.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TS-9) InkAPI.h and RemapPlugin.h are missing
from /usr/local/include
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778020#action_12778020 ]
Leif Hedstrom commented on TS-9:
--------------------------------
Lets install these into a subdir under /usr/local/include (or $PREFIX/include), I'd like to propose:
.../include/ts
.../include/ts/api.h
.../include/ts/atomic.h [this would be a new file)
.../include/ts/remap.h
This renames InkAPI.h to just ts/api.h and RemapAPI (sic) to ts/remap.h.
Thoughts?
> InkAPI.h and RemapPlugin.h are missing from /usr/local/include
> ---------------------------------------------------------------
>
> Key: TS-9
> URL: https://issues.apache.org/jira/browse/TS-9
> Project: Traffic Server
> Issue Type: Bug
> Components: Build
> Reporter: Leif Hedstrom
> Assignee: Andrew Hsu
>
> I think we need to "install" ("gmake install") these two files into $PREFIX/include. This is to make building plugins easier.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TS-9) InkAPI.h and RemapPlugin.h are missing
from /usr/local/include
Posted by "Andrew Hsu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-9?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Hsu reassigned TS-9:
---------------------------
Assignee: Andrew Hsu
> InkAPI.h and RemapPlugin.h are missing from /usr/local/include
> ---------------------------------------------------------------
>
> Key: TS-9
> URL: https://issues.apache.org/jira/browse/TS-9
> Project: Traffic Server
> Issue Type: Bug
> Components: Build
> Reporter: Leif Hedstrom
> Assignee: Andrew Hsu
>
> I think we need to "install" ("gmake install") these two files into $PREFIX/include. This is to make building plugins easier.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TS-9) InkAPI.h and RemapPlugin.h are missing from
/usr/local/include
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-9?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom updated TS-9:
---------------------------
Attachment: TS-9-Private_h.patch
This is the final "change" for the file name rename. This assume the following commands as well:
svn move proxy/api/include/InkAPIPrivate.h proxy/api/include/ts_private.h
svn move proxy/api/include/InkAPIPrivateFrozen.h proxy/api/include/ts_private_frozen.h
> InkAPI.h and RemapPlugin.h are missing from /usr/local/include
> ---------------------------------------------------------------
>
> Key: TS-9
> URL: https://issues.apache.org/jira/browse/TS-9
> Project: Traffic Server
> Issue Type: Bug
> Components: Build
> Reporter: Leif Hedstrom
> Assignee: Leif Hedstrom
> Fix For: 2.0.0a
>
> Attachments: TS-9-InkAPI-h.patch, TS-9-Private_h.patch, TS-9-Remap_h.patch
>
>
> I think we need to "install" ("gmake install") these two files into $PREFIX/include. This is to make building plugins easier.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.