You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@weex.apache.org by GitBox <gi...@apache.org> on 2018/10/29 13:42:18 UTC

[GitHub] wqyfavor commented on a change in pull request #1644: [WEEX-648][iOS]native batch for dom operations generating from JavaScript

wqyfavor commented on a change in pull request #1644: [WEEX-648][iOS]native batch for dom operations generating from JavaScript
URL: https://github.com/apache/incubator-weex/pull/1644#discussion_r228928742
 
 

 ##########
 File path: ios/sdk/WeexSDK/Sources/Manager/WXComponentManager.mm
 ##########
 @@ -991,8 +991,38 @@ - (void) _printFlexComponentFrame:(WXComponent *)component
 
 - (void)_syncUITasks
 {
-    NSArray<dispatch_block_t> *blocks = _uiTaskQueue;
-    _uiTaskQueue = [NSMutableArray array];
+    static NSInteger _syncUITaskCount = 0;
 
 Review comment:
   _syncUITaskCount不能声明为static，不同的instance有不同的componentManager不能共用一个变量。

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services