You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Raghu Angadi (JIRA)" <ji...@apache.org> on 2008/08/22 06:32:44 UTC

[jira] Created: (HADOOP-3995) renameTo(src, dst) does not restore src name in case of quota failure.

renameTo(src, dst) does not restore src name in case of quota failure.
----------------------------------------------------------------------

                 Key: HADOOP-3995
                 URL: https://issues.apache.org/jira/browse/HADOOP-3995
             Project: Hadoop Core
          Issue Type: Bug
    Affects Versions: 0.18.0
            Reporter: Raghu Angadi
            Assignee: Raghu Angadi


How to reproduce :

set up quota such that 'hadoop -mv src dst' results in a 'quota excceeded' exception.

* Now try : {{hadoop -mv src dst/src}} 
   ** This fails as expected and 'src' exists after this as expected

* Now try : {{hadoop -mv src dst/diffname}}
   ** This fails as expected
   ** buf 'src' does not exist after this, you will find 'diffname' directory in its place

I think fix should go into 0.18.1

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3995) renameTo(src, dst) does not restore src name in case of quota failure.

Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625799#action_12625799 ] 

Raghu Angadi commented on HADOOP-3995:
--------------------------------------

Javadoc warnings are unrelated.

> renameTo(src, dst) does not restore src name in case of quota failure.
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-3995
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3995
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.0
>            Reporter: Raghu Angadi
>            Assignee: Raghu Angadi
>            Priority: Blocker
>             Fix For: 0.18.1
>
>         Attachments: HADOOP-3995-018.patch, HADOOP-3995-018.patch, HADOOP-3995-trunk.patch
>
>
> How to reproduce :
> set up quota such that 'hadoop -mv src dst' results in a 'quota excceeded' exception.
> * Now try : {{hadoop -mv src dst/diffname}}
>    ** This fails as expected
>    ** buf 'src' does not exist after this, you will find 'diffname' directory in its place
> I think fix should go into 0.18.1

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3995) renameTo(src, dst) does not restore src name in case of quota failure.

Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Raghu Angadi updated HADOOP-3995:
---------------------------------

    Component/s: dfs

> renameTo(src, dst) does not restore src name in case of quota failure.
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-3995
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3995
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.0
>            Reporter: Raghu Angadi
>            Assignee: Raghu Angadi
>         Attachments: HADOOP-3995-018.patch
>
>
> How to reproduce :
> set up quota such that 'hadoop -mv src dst' results in a 'quota excceeded' exception.
> * Now try : {{hadoop -mv src dst/src}} 
>    ** This fails as expected and 'src' exists after this as expected
> * Now try : {{hadoop -mv src dst/diffname}}
>    ** This fails as expected
>    ** buf 'src' does not exist after this, you will find 'diffname' directory in its place
> I think fix should go into 0.18.1

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3995) renameTo(src, dst) does not restore src name in case of quota failure.

Posted by "Robert Chansler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Chansler updated HADOOP-3995:
------------------------------------

         Priority: Blocker  (was: Major)
    Fix Version/s: 0.18.1

> renameTo(src, dst) does not restore src name in case of quota failure.
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-3995
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3995
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.0
>            Reporter: Raghu Angadi
>            Assignee: Raghu Angadi
>            Priority: Blocker
>             Fix For: 0.18.1
>
>         Attachments: HADOOP-3995-018.patch, HADOOP-3995-018.patch
>
>
> How to reproduce :
> set up quota such that 'hadoop -mv src dst' results in a 'quota excceeded' exception.
> * Now try : {{hadoop -mv src dst/src}} 
>    ** This fails as expected and 'src' exists after this as expected
> * Now try : {{hadoop -mv src dst/diffname}}
>    ** This fails as expected
>    ** buf 'src' does not exist after this, you will find 'diffname' directory in its place
> I think fix should go into 0.18.1

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3995) renameTo(src, dst) does not restore src name in case of quota failure.

Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Raghu Angadi updated HADOOP-3995:
---------------------------------

    Status: Patch Available  (was: Open)

> renameTo(src, dst) does not restore src name in case of quota failure.
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-3995
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3995
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.0
>            Reporter: Raghu Angadi
>            Assignee: Raghu Angadi
>         Attachments: HADOOP-3995-018.patch
>
>
> How to reproduce :
> set up quota such that 'hadoop -mv src dst' results in a 'quota excceeded' exception.
> * Now try : {{hadoop -mv src dst/src}} 
>    ** This fails as expected and 'src' exists after this as expected
> * Now try : {{hadoop -mv src dst/diffname}}
>    ** This fails as expected
>    ** buf 'src' does not exist after this, you will find 'diffname' directory in its place
> I think fix should go into 0.18.1

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3995) renameTo(src, dst) does not restore src name in case of quota failure.

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625617#action_12625617 ] 

Hadoop QA commented on HADOOP-3995:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12388759/HADOOP-3995-trunk.patch
  against trunk revision 688936.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    -1 javadoc.  The javadoc tool appears to have generated 1 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3100/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3100/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3100/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3100/console

This message is automatically generated.

> renameTo(src, dst) does not restore src name in case of quota failure.
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-3995
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3995
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.0
>            Reporter: Raghu Angadi
>            Assignee: Raghu Angadi
>            Priority: Blocker
>             Fix For: 0.18.1
>
>         Attachments: HADOOP-3995-018.patch, HADOOP-3995-018.patch, HADOOP-3995-trunk.patch
>
>
> How to reproduce :
> set up quota such that 'hadoop -mv src dst' results in a 'quota excceeded' exception.
> * Now try : {{hadoop -mv src dst/diffname}}
>    ** This fails as expected
>    ** buf 'src' does not exist after this, you will find 'diffname' directory in its place
> I think fix should go into 0.18.1

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3995) renameTo(src, dst) does not restore src name in case of quota failure.

Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Raghu Angadi updated HADOOP-3995:
---------------------------------

       Resolution: Fixed
    Fix Version/s: 0.19.0
     Release Note: 
In case of quota failure on HDFS, rename does not restore source filename.

     Hadoop Flags: [Reviewed]
           Status: Resolved  (was: Patch Available)

I just committeted this.

> renameTo(src, dst) does not restore src name in case of quota failure.
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-3995
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3995
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.0
>            Reporter: Raghu Angadi
>            Assignee: Raghu Angadi
>            Priority: Blocker
>             Fix For: 0.18.1, 0.19.0
>
>         Attachments: HADOOP-3995-018.patch, HADOOP-3995-018.patch, HADOOP-3995-trunk.patch
>
>
> How to reproduce :
> set up quota such that 'hadoop -mv src dst' results in a 'quota excceeded' exception.
> * Now try : {{hadoop -mv src dst/diffname}}
>    ** This fails as expected
>    ** buf 'src' does not exist after this, you will find 'diffname' directory in its place
> I think fix should go into 0.18.1

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3995) renameTo(src, dst) does not restore src name in case of quota failure.

Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Raghu Angadi updated HADOOP-3995:
---------------------------------

    Attachment: HADOOP-3995-018.patch

A simple fix is attached. This adds a test case in TestQuota

> renameTo(src, dst) does not restore src name in case of quota failure.
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-3995
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3995
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.0
>            Reporter: Raghu Angadi
>            Assignee: Raghu Angadi
>         Attachments: HADOOP-3995-018.patch
>
>
> How to reproduce :
> set up quota such that 'hadoop -mv src dst' results in a 'quota excceeded' exception.
> * Now try : {{hadoop -mv src dst/src}} 
>    ** This fails as expected and 'src' exists after this as expected
> * Now try : {{hadoop -mv src dst/diffname}}
>    ** This fails as expected
>    ** buf 'src' does not exist after this, you will find 'diffname' directory in its place
> I think fix should go into 0.18.1

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3995) renameTo(src, dst) does not restore src name in case of quota failure.

Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Raghu Angadi updated HADOOP-3995:
---------------------------------

    Attachment: HADOOP-3995-018.patch

> renameTo(src, dst) does not restore src name in case of quota failure.
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-3995
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3995
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.0
>            Reporter: Raghu Angadi
>            Assignee: Raghu Angadi
>         Attachments: HADOOP-3995-018.patch, HADOOP-3995-018.patch
>
>
> How to reproduce :
> set up quota such that 'hadoop -mv src dst' results in a 'quota excceeded' exception.
> * Now try : {{hadoop -mv src dst/src}} 
>    ** This fails as expected and 'src' exists after this as expected
> * Now try : {{hadoop -mv src dst/diffname}}
>    ** This fails as expected
>    ** buf 'src' does not exist after this, you will find 'diffname' directory in its place
> I think fix should go into 0.18.1

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3995) renameTo(src, dst) does not restore src name in case of quota failure.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12626585#action_12626585 ] 

Hudson commented on HADOOP-3995:
--------------------------------

Integrated in Hadoop-trunk #586 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/586/])

> renameTo(src, dst) does not restore src name in case of quota failure.
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-3995
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3995
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.0
>            Reporter: Raghu Angadi
>            Assignee: Raghu Angadi
>            Priority: Blocker
>             Fix For: 0.18.1, 0.19.0
>
>         Attachments: HADOOP-3995-018.patch, HADOOP-3995-018.patch, HADOOP-3995-trunk.patch
>
>
> How to reproduce :
> set up quota such that 'hadoop -mv src dst' results in a 'quota excceeded' exception.
> * Now try : {{hadoop -mv src dst/diffname}}
>    ** This fails as expected
>    ** buf 'src' does not exist after this, you will find 'diffname' directory in its place
> I think fix should go into 0.18.1

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3995) renameTo(src, dst) does not restore src name in case of quota failure.

Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625785#action_12625785 ] 

Hairong Kuang commented on HADOOP-3995:
---------------------------------------

+1 The patch looks good.

> renameTo(src, dst) does not restore src name in case of quota failure.
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-3995
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3995
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.0
>            Reporter: Raghu Angadi
>            Assignee: Raghu Angadi
>            Priority: Blocker
>             Fix For: 0.18.1
>
>         Attachments: HADOOP-3995-018.patch, HADOOP-3995-018.patch, HADOOP-3995-trunk.patch
>
>
> How to reproduce :
> set up quota such that 'hadoop -mv src dst' results in a 'quota excceeded' exception.
> * Now try : {{hadoop -mv src dst/diffname}}
>    ** This fails as expected
>    ** buf 'src' does not exist after this, you will find 'diffname' directory in its place
> I think fix should go into 0.18.1

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3995) renameTo(src, dst) does not restore src name in case of quota failure.

Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Raghu Angadi updated HADOOP-3995:
---------------------------------

    Attachment: HADOOP-3995-trunk.patch

> renameTo(src, dst) does not restore src name in case of quota failure.
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-3995
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3995
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.0
>            Reporter: Raghu Angadi
>            Assignee: Raghu Angadi
>            Priority: Blocker
>             Fix For: 0.18.1
>
>         Attachments: HADOOP-3995-018.patch, HADOOP-3995-018.patch, HADOOP-3995-trunk.patch
>
>
> How to reproduce :
> set up quota such that 'hadoop -mv src dst' results in a 'quota excceeded' exception.
> * Now try : {{hadoop -mv src dst/src}} 
>    ** This fails as expected and 'src' exists after this as expected
> * Now try : {{hadoop -mv src dst/diffname}}
>    ** This fails as expected
>    ** buf 'src' does not exist after this, you will find 'diffname' directory in its place
> I think fix should go into 0.18.1

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3995) renameTo(src, dst) does not restore src name in case of quota failure.

Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Raghu Angadi updated HADOOP-3995:
---------------------------------

    Description: 
How to reproduce :

set up quota such that 'hadoop -mv src dst' results in a 'quota excceeded' exception.

* Now try : {{hadoop -mv src dst/diffname}}
   ** This fails as expected
   ** buf 'src' does not exist after this, you will find 'diffname' directory in its place

I think fix should go into 0.18.1

  was:
How to reproduce :

set up quota such that 'hadoop -mv src dst' results in a 'quota excceeded' exception.

* Now try : {{hadoop -mv src dst/src}} 
   ** This fails as expected and 'src' exists after this as expected

* Now try : {{hadoop -mv src dst/diffname}}
   ** This fails as expected
   ** buf 'src' does not exist after this, you will find 'diffname' directory in its place

I think fix should go into 0.18.1


> renameTo(src, dst) does not restore src name in case of quota failure.
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-3995
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3995
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.0
>            Reporter: Raghu Angadi
>            Assignee: Raghu Angadi
>            Priority: Blocker
>             Fix For: 0.18.1
>
>         Attachments: HADOOP-3995-018.patch, HADOOP-3995-018.patch, HADOOP-3995-trunk.patch
>
>
> How to reproduce :
> set up quota such that 'hadoop -mv src dst' results in a 'quota excceeded' exception.
> * Now try : {{hadoop -mv src dst/diffname}}
>    ** This fails as expected
>    ** buf 'src' does not exist after this, you will find 'diffname' directory in its place
> I think fix should go into 0.18.1

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.