You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/12/30 20:39:17 UTC

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #2627: OS internal function should indicate the error by return negative value

Ouss4 commented on pull request #2627:
URL: https://github.com/apache/incubator-nuttx/pull/2627#issuecomment-752751238


   BTW the checks are failing because of #2618.  The following should fix the issue but I don't know if there is a better solution.
   
   ```diff
   diff --git a/fs/vfs/fs_unlink.c b/fs/vfs/fs_unlink.c
   index 5b0b6053f7..490fcd0059 100644
   --- a/fs/vfs/fs_unlink.c
   +++ b/fs/vfs/fs_unlink.c
   @@ -191,8 +191,10 @@ int nx_unlink(FAR const char *pathname)
      RELEASE_SEARCH(&desc);
      return OK;
   
   +#ifndef CONFIG_DISABLE_PSEUDOFS_OPERATIONS
    errout_with_sem:
      inode_semgive();
   +#endif
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org