You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/06/26 16:17:48 UTC
[GitHub] [apisix-dashboard] iamayushdas opened a new pull request #1957: feat: added husky for pre-commit
iamayushdas opened a new pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957
Please answer these questions before submitting a pull request, **or your PR will get closed**.
- [x] auto prettier
- [ ] auto-check commit message
**Why submit this pull request?**
- [ ] Bugfix
- [x] New feature provided
- [x] Improve performance
- [ ] Backport patches
**What changes will this PR take into?**
Added auto prettier via husky
**Related issues**
fix/resolve #1746 #1900
**Checklist:**
- [x] Did you explain what problem does this PR solve? Or what new features have been added?
- [ ] Have you added corresponding test cases?
- [ ] Have you modified the corresponding document?
- [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #1957: feat: added husky for pre-commit
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957#issuecomment-869025138
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1957](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a8ab519) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/e3debe5d314010efa7704c7538e3ae7b2025d28e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e3debe5) will **decrease** coverage by `14.58%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1957 +/- ##
===========================================
- Coverage 66.91% 52.32% -14.59%
===========================================
Files 179 38 -141
Lines 6537 2687 -3850
Branches 753 0 -753
===========================================
- Hits 4374 1406 -2968
+ Misses 1897 1093 -804
+ Partials 266 188 -78
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test | `?` | |
| backend-e2e-test-ginkgo | `?` | |
| backend-unit-test | `52.32% <ø> (-0.04%)` | :arrow_down: |
| frontend-e2e-test | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [api/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL21haW4uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-70.00%)` | :arrow_down: |
| [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: |
| [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: |
| [api/internal/handler/handler.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGFuZGxlci5nbw==) | `42.59% <0.00%> (-35.19%)` | :arrow_down: |
| ... and [163 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e3debe5...a8ab519](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1957: feat: added husky for pre-commit
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957#issuecomment-869091547
If we install something in some package (eg: husky) it will create the package.json, and also IMO that package.json with script consisting in it is the same package.json that will produce while installing husky
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1957: feat: added husky for pre-commit
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957#issuecomment-880366395
cc @juzhiyuan @liuxiran @LiteSun @guoqqqi need you review again and lets get this feature merged,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on a change in pull request #1957: feat: added husky for pre-commit
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on a change in pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957#discussion_r659187160
##########
File path: web/src/global.tsx
##########
@@ -25,8 +25,8 @@ import defaultSettings from '../config/defaultSettings';
// see https://github.com/suren-atoyan/monaco-react/issues/168
loader.config({ paths: { vs: '/monaco-editor/min/vs' } });
-if (getLocale() === 'zh-CN'){
- loader.config({ "vs/nls": { availableLanguages: { "*": 'zh-cn' } } });
+if (getLocale() === 'zh-CN') {
Review comment:
staged this file to check the husky
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1957: feat: added husky for pre-commit
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957#issuecomment-869025033
:construction_worker: Deploy Preview for *apisix-dashboard* processing.
:hammer: Explore the source changes: db753ef7a1e0e4137a40a5a7d4d52f5f64d8d619
:mag: Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/60d7eb086529e2000773f3a0](https://app.netlify.com/sites/apisix-dashboard/deploys/60d7eb086529e2000773f3a0?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1957: feat: added husky for pre-commit
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957#issuecomment-869096005
cc @bzp2010 @liuxiran @LiteSun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1957: feat: added husky for pre-commit
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1957: feat: added husky for pre-commit
Posted by GitBox <gi...@apache.org>.
nic-chen commented on a change in pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957#discussion_r670225183
##########
File path: web/src/constants.ts
##########
@@ -28,6 +28,7 @@ export const codeMessage = {
422: '当创建一个对象时，发生一个验证错误。',
500: '服务器发生错误，请检查服务器。',
502: '网关错误。',
+
Review comment:
why change this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1957: feat: added husky for pre-commit
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957#issuecomment-873525918
search_ route.spec.js test is failing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1957: feat: added husky for pre-commit
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957#issuecomment-869025138
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1957](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a8ab519) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/e3debe5d314010efa7704c7538e3ae7b2025d28e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e3debe5) will **decrease** coverage by `3.39%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1957 +/- ##
==========================================
- Coverage 66.91% 63.51% -3.40%
==========================================
Files 179 179
Lines 6537 6551 +14
Branches 753 753
==========================================
- Hits 4374 4161 -213
- Misses 1897 2118 +221
- Partials 266 272 +6
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test | `44.09% <ø> (-0.48%)` | :arrow_down: |
| backend-e2e-test-ginkgo | `?` | |
| backend-unit-test | `52.32% <ø> (-0.04%)` | :arrow_down: |
| frontend-e2e-test | `64.01% <100.00%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [web/src/global.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9nbG9iYWwudHN4) | `36.58% <100.00%> (ø)` | |
| [api/internal/core/migrate/conflict.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvbWlncmF0ZS9jb25mbGljdC5nbw==) | `0.00% <0.00%> (-76.93%)` | :arrow_down: |
| [api/internal/core/migrate/migrate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvbWlncmF0ZS9taWdyYXRlLmdv) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [api/internal/core/migrate/dataset.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvbWlncmF0ZS9kYXRhc2V0Lmdv) | `0.00% <0.00%> (-52.73%)` | :arrow_down: |
| [api/internal/handler/migrate/migrate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbWlncmF0ZS9taWdyYXRlLmdv) | `5.55% <0.00%> (-51.86%)` | :arrow_down: |
| [api/internal/handler/healthz/healthz.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGVhbHRoei9oZWFsdGh6Lmdv) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
| [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `31.93% <0.00%> (-23.53%)` | :arrow_down: |
| [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `81.25% <0.00%> (-18.75%)` | :arrow_down: |
| [api/cmd/root.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9yb290Lmdv) | `45.45% <0.00%> (-13.31%)` | :arrow_down: |
| [api/internal/log/log.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2xvZy9sb2cuZ28=) | `40.00% <0.00%> (-10.00%)` | :arrow_down: |
| ... and [16 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e3debe5...a8ab519](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas edited a comment on pull request #1957: feat: added husky for pre-commit
Posted by GitBox <gi...@apache.org>.
iamayushdas edited a comment on pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957#issuecomment-869088946
> Hi, I just checked this PR, and your solution is creating a Husky under the root folder, actually, we only want to format the `web/` folder 🤔
>
>
>
> Do we have some reference or examples using this way?
@juzhiyuan
https://typicode.github.io/husky/#/?id=custom-directory
It is said that it has to be installed inside the directory where `.git` exits because husky is designed in a way that then only it can look for the hooks that are present in` .git` folder, but the preparation could be done in any folder that consists of the package.json
The above reference is same as our case we have .git in root folder but package.json in our /web where husky is to be executed in .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1957: feat: added husky for pre-commit
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957#issuecomment-869084753
Hi, I just checked this PR, and your solution is creating a Husky under the root folder, actually, we only want to format the `web/` folder 🤔
Do we have some reference or examples using this way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on pull request #1957: feat: added husky for pre-commit
Posted by GitBox <gi...@apache.org>.
liuxiran commented on pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957#issuecomment-880254629
we can try to import `uuid` which is already one of our dependencies to generate the `uid` for the file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1957: feat: added husky for pre-commit
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957#issuecomment-873522345
@liuxiran @LiteSun check once again, is it fine now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1957: feat: added husky for pre-commit
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957#issuecomment-869025033
👷 Deploy Preview for *apisix-dashboard* processing.
🔨 Explore the source changes: 63af84ce84678b49a0e12255fd2bbd5e7bb968af
🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/60eface394cb71000784566d](https://app.netlify.com/sites/apisix-dashboard/deploys/60eface394cb71000784566d?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1957: feat: added husky for pre-commit
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957#issuecomment-869091330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1957: feat: added husky for pre-commit
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957#issuecomment-869092565
cc @juzhiyuan check it again please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1957: feat: added husky for pre-commit
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957#issuecomment-869091226
that's fine, but this PR put package.json under the root folder, right?
I think it should be at the `web` folder just like this example:
https://typicode.github.io/husky/#/?id=custom-directory
```json
// package.json
{
"scripts": {
"prepare": "cd .. && husky install front/.husky"
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1957: feat: added husky for pre-commit
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957#issuecomment-869025033
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1957: feat: added husky for pre-commit
Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957#issuecomment-869025033
:construction_worker: Deploy Preview for *apisix-dashboard* processing.
:hammer: Explore the source changes: a8ab519dae52de5e6a2bc8edb1aa8dbc32762c51
:mag: Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/60d7531fc3aacc00081f745c](https://app.netlify.com/sites/apisix-dashboard/deploys/60d7531fc3aacc00081f745c?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1957: feat: added husky for pre-commit
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957#issuecomment-869025033
👷 Deploy Preview for *apisix-dashboard* processing.
🔨 Explore the source changes: 52c22e44df094b534cc2829398393b80c451e9a3
🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/60f52fa87129aa00070e5cfe](https://app.netlify.com/sites/apisix-dashboard/deploys/60f52fa87129aa00070e5cfe?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1957: feat: added husky for pre-commit
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957#issuecomment-872399927
I agree @liuxiran , it is important for tests, thanks for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1957: feat: added husky for pre-commit
Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957#discussion_r668752619
##########
File path: web/.eslintignore
##########
@@ -1,4 +1,5 @@
/lambda/
/scripts
/config
-.history
\ No newline at end of file
+.history
+.eslintrc.js
Review comment:
empty line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on pull request #1957: feat: added husky for pre-commit
Posted by GitBox <gi...@apache.org>.
LiteSun commented on pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957#issuecomment-872655248
Agree to put cypress into include list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1957: feat: added husky for pre-commit
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957#issuecomment-869025033
✔️ Deploy Preview for *apisix-dashboard* ready!
🔨 Explore the source changes: 63af84ce84678b49a0e12255fd2bbd5e7bb968af
🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/60eface394cb71000784566d](https://app.netlify.com/sites/apisix-dashboard/deploys/60eface394cb71000784566d?utm_source=github&utm_campaign=bot_dl)
😎 Browse the preview: [https://deploy-preview-1957--apisix-dashboard.netlify.app/](https://deploy-preview-1957--apisix-dashboard.netlify.app/?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1957: feat: added husky for pre-commit
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957#issuecomment-869025033
:construction_worker: Deploy Preview for *apisix-dashboard* processing.
:hammer: Explore the source changes: 56d1e1dd452b8cc263258e4c90dc040799c56807
:mag: Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/60e140647c424f000709d4e7](https://app.netlify.com/sites/apisix-dashboard/deploys/60e140647c424f000709d4e7?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1957: feat: added husky for pre-commit
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957#issuecomment-869025138
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1957](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5ab9679) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/e3debe5d314010efa7704c7538e3ae7b2025d28e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e3debe5) will **decrease** coverage by `2.96%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1957 +/- ##
==========================================
- Coverage 66.91% 63.95% -2.97%
==========================================
Files 179 122 -57
Lines 6537 3154 -3383
Branches 753 753
==========================================
- Hits 4374 2017 -2357
+ Misses 1897 1137 -760
+ Partials 266 0 -266
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test | `?` | |
| backend-e2e-test-ginkgo | `?` | |
| backend-unit-test | `?` | |
| frontend-e2e-test | `63.95% <66.66%> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [web/src/pages/Consumer/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9DcmVhdGUudHN4) | `76.08% <50.00%> (ø)` | |
| [web/src/global.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9nbG9iYWwudHN4) | `36.58% <100.00%> (ø)` | |
| [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `68.85% <0.00%> (-3.28%)` | :arrow_down: |
| [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | | |
| [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | | |
| [api/internal/filter/recover.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZWNvdmVyLmdv) | | |
| [api/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL21haW4uZ28=) | | |
| [api/internal/core/migrate/conflict.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvbWlncmF0ZS9jb25mbGljdC5nbw==) | | |
| [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | | |
| [api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==) | | |
| ... and [50 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e3debe5...5ab9679](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1957: feat: added husky for pre-commit
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957#issuecomment-869088946
> Hi, I just checked this PR, and your solution is creating a Husky under the root folder, actually, we only want to format the `web/` folder 🤔
>
>
>
> Do we have some reference or examples using this way?
https://typicode.github.io/husky/#/?id=custom-directory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1957: feat: added husky for pre-commit
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957#issuecomment-869025138
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1957](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a8ab519) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/e3debe5d314010efa7704c7538e3ae7b2025d28e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e3debe5) will **decrease** coverage by `3.85%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1957 +/- ##
==========================================
- Coverage 66.91% 63.05% -3.86%
==========================================
Files 179 57 -122
Lines 6537 3397 -3140
Branches 753 0 -753
==========================================
- Hits 4374 2142 -2232
+ Misses 1897 983 -914
- Partials 266 272 +6
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test | `44.09% <ø> (-0.48%)` | :arrow_down: |
| backend-e2e-test-ginkgo | `?` | |
| backend-unit-test | `52.32% <ø> (-0.04%)` | :arrow_down: |
| frontend-e2e-test | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [api/internal/core/migrate/conflict.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvbWlncmF0ZS9jb25mbGljdC5nbw==) | `0.00% <0.00%> (-76.93%)` | :arrow_down: |
| [api/internal/core/migrate/migrate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvbWlncmF0ZS9taWdyYXRlLmdv) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [api/internal/core/migrate/dataset.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvbWlncmF0ZS9kYXRhc2V0Lmdv) | `0.00% <0.00%> (-52.73%)` | :arrow_down: |
| [api/internal/handler/migrate/migrate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbWlncmF0ZS9taWdyYXRlLmdv) | `5.55% <0.00%> (-51.86%)` | :arrow_down: |
| [api/internal/handler/healthz/healthz.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGVhbHRoei9oZWFsdGh6Lmdv) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
| [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `31.93% <0.00%> (-23.53%)` | :arrow_down: |
| [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `81.25% <0.00%> (-18.75%)` | :arrow_down: |
| [api/cmd/root.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9yb290Lmdv) | `45.45% <0.00%> (-13.31%)` | :arrow_down: |
| [api/internal/log/log.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2xvZy9sb2cuZ28=) | `40.00% <0.00%> (-10.00%)` | :arrow_down: |
| [api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==) | `90.47% <0.00%> (-9.53%)` | :arrow_down: |
| ... and [136 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e3debe5...a8ab519](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1957: feat: added husky for pre-commit
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957#issuecomment-880366140
cc
> 
>
> we can try to import `uuid` which is already one of our dependencies to generate the `uid` for the file
we can add this in later PR, is that cool for you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1957: feat: added husky for pre-commit
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957#issuecomment-869025033
:construction_worker: Deploy Preview for *apisix-dashboard* processing.
:hammer: Explore the source changes: 5cce80e7f756ac3c8e01b3cccb2c48e8bf03f85a
:mag: Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/60e13f6d76db050007c642fa](https://app.netlify.com/sites/apisix-dashboard/deploys/60e13f6d76db050007c642fa?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1957: feat: added husky for pre-commit
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957#issuecomment-869025138
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1957](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (244d5f2) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/1e55aa3d531e6cbe5ca90c1dd0d2bfc56bfe1506?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1e55aa3) will **decrease** coverage by `0.06%`.
> The diff coverage is `57.14%`.
> :exclamation: Current head 244d5f2 differs from pull request most recent head 52c22e4. Consider uploading reports for the commit 52c22e4 to get more accurate results
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1957 +/- ##
==========================================
- Coverage 64.01% 63.95% -0.07%
==========================================
Files 122 122
Lines 3154 3154
Branches 753 753
==========================================
- Hits 2019 2017 -2
- Misses 1135 1137 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| frontend-e2e-test | `63.95% <57.14%> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../src/pages/Route/components/Step1/ProxyRewrite.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAxL1Byb3h5UmV3cml0ZS50c3g=) | `94.44% <ø> (ø)` | |
| [web/src/pages/Route/components/Step3/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAzL2luZGV4LnRzeA==) | `51.85% <0.00%> (ø)` | |
| [web/src/pages/Consumer/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9DcmVhdGUudHN4) | `76.08% <50.00%> (ø)` | |
| [web/src/global.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9nbG9iYWwudHN4) | `36.58% <100.00%> (ø)` | |
| [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `68.85% <0.00%> (-3.28%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1e55aa3...52c22e4](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1957: feat: added husky for pre-commit
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957#issuecomment-869025033
:heavy_check_mark: Deploy Preview for *apisix-dashboard* ready!
:hammer: Explore the source changes: 56d1e1dd452b8cc263258e4c90dc040799c56807
:mag: Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/60e140647c424f000709d4e7](https://app.netlify.com/sites/apisix-dashboard/deploys/60e140647c424f000709d4e7?utm_source=github&utm_campaign=bot_dl)
:sunglasses: Browse the preview: [https://deploy-preview-1957--apisix-dashboard.netlify.app/](https://deploy-preview-1957--apisix-dashboard.netlify.app/?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas edited a comment on pull request #1957: feat: added husky for pre-commit
Posted by GitBox <gi...@apache.org>.
iamayushdas edited a comment on pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957#issuecomment-880366140
> 
>
> we can try to import `uuid` which is already one of our dependencies to generate the `uid` for the file
we can add this in later PR, is that cool for you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1957: feat: added husky for pre-commit
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957#issuecomment-882974432
cc @LiteSun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1957: feat: added husky for pre-commit
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957#issuecomment-880398502
@nic-chen can i have your review here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on a change in pull request #1957: feat: added husky for pre-commit
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on a change in pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957#discussion_r670233267
##########
File path: web/src/constants.ts
##########
@@ -28,6 +28,7 @@ export const codeMessage = {
422: '当创建一个对象时，发生一个验证错误。',
500: '服务器发生错误，请检查服务器。',
502: '网关错误。',
+
Review comment:
From that i was just testing husky, it will not harm any code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1957: feat: added husky for pre-commit
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957#issuecomment-869092287
Okay okay, i guess i understood you now, i am working on it as you want
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1957: feat: added husky for pre-commit
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957#issuecomment-882974432
cc @LiteSun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi commented on pull request #1957: feat: added husky for pre-commit
Posted by GitBox <gi...@apache.org>.
guoqqqi commented on pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957#issuecomment-873624159
I think we should add some assertions to these open drawer tests to make them as stable as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas edited a comment on pull request #1957: feat: added husky for pre-commit
Posted by GitBox <gi...@apache.org>.
iamayushdas edited a comment on pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957#issuecomment-869088946
> Hi, I just checked this PR, and your solution is creating a Husky under the root folder, actually, we only want to format the `web/` folder 🤔
>
>
>
> Do we have some reference or examples using this way?
@juzhiyuan
https://typicode.github.io/husky/#/?id=custom-directory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1957: feat: added husky for pre-commit
Posted by GitBox <gi...@apache.org>.
nic-chen commented on a change in pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957#discussion_r670321821
##########
File path: web/src/constants.ts
##########
@@ -28,6 +28,7 @@ export const codeMessage = {
422: '当创建一个对象时，发生一个验证错误。',
500: '服务器发生错误，请检查服务器。',
502: '网关错误。',
+
Review comment:
Yes, but please don't make unnecessary changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1957: feat: added husky for pre-commit
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957#issuecomment-869025033
:heavy_check_mark: Deploy Preview for *apisix-dashboard* ready!
:hammer: Explore the source changes: a8ab519dae52de5e6a2bc8edb1aa8dbc32762c51
:mag: Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/60d7531fc3aacc00081f745c](https://app.netlify.com/sites/apisix-dashboard/deploys/60d7531fc3aacc00081f745c?utm_source=github&utm_campaign=bot_dl)
:sunglasses: Browse the preview: [https://deploy-preview-1957--apisix-dashboard.netlify.app/](https://deploy-preview-1957--apisix-dashboard.netlify.app/?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1957: feat: added husky for pre-commit
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957#issuecomment-869025192
cc @juzhiyuan @guoqqqi @liuxiran
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1957: feat: added husky for pre-commit
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957#issuecomment-869025033
:heavy_check_mark: Deploy Preview for *apisix-dashboard* ready!
:hammer: Explore the source changes: 5ab9679e876536376d8b220d587ec29190253254
:mag: Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/60d7ece63566ba00088dbfcd](https://app.netlify.com/sites/apisix-dashboard/deploys/60d7ece63566ba00088dbfcd?utm_source=github&utm_campaign=bot_dl)
:sunglasses: Browse the preview: [https://deploy-preview-1957--apisix-dashboard.netlify.app/](https://deploy-preview-1957--apisix-dashboard.netlify.app/?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1957: feat: added husky for pre-commit
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957#issuecomment-882974432
cc @LiteSun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1957: feat: added husky for pre-commit
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957#issuecomment-869025033
✔️ Deploy Preview for *apisix-dashboard* ready!
🔨 Explore the source changes: 52c22e44df094b534cc2829398393b80c451e9a3
🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/60f52fa87129aa00070e5cfe](https://app.netlify.com/sites/apisix-dashboard/deploys/60f52fa87129aa00070e5cfe?utm_source=github&utm_campaign=bot_dl)
😎 Browse the preview: [https://deploy-preview-1957--apisix-dashboard.netlify.app/](https://deploy-preview-1957--apisix-dashboard.netlify.app/?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1957: feat: added husky for pre-commit
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957#issuecomment-869025138
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1957](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8288b63) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/e3debe5d314010efa7704c7538e3ae7b2025d28e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e3debe5) will **decrease** coverage by `14.62%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 8288b63 differs from pull request most recent head db753ef. Consider uploading reports for the commit db753ef to get more accurate results
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1957 +/- ##
===========================================
- Coverage 66.91% 52.28% -14.63%
===========================================
Files 179 38 -141
Lines 6537 2687 -3850
Branches 753 0 -753
===========================================
- Hits 4374 1405 -2969
+ Misses 1897 1094 -803
+ Partials 266 188 -78
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test | `?` | |
| backend-e2e-test-ginkgo | `?` | |
| backend-unit-test | `52.28% <0.00%> (-0.08%)` | :arrow_down: |
| frontend-e2e-test | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [api/internal/utils/pid.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3BpZC5nbw==) | `0.00% <0.00%> (-23.53%)` | :arrow_down: |
| [api/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL21haW4uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-70.00%)` | :arrow_down: |
| [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: |
| [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: |
| ... and [161 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e3debe5...db753ef](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on pull request #1957: feat: added husky for pre-commit
Posted by GitBox <gi...@apache.org>.
liuxiran commented on pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957#issuecomment-872398802
I tried in my local env, and found that when I tried to commit a `js` file e.g. cypress test files or `.eslintrc.js`, an error will occur:
That is because we did not put these js files into `tsconfig.json` include list, or we can also choose to ignore them
I suggest to put `cypress` into include list, as for other config files like `.eslintrc.js`, we can put them into `.eslintignore` file
what do you think?
cc @juzhiyuan @guoqqqi @iamayushdas @LiteSun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on pull request #1957: feat: added husky for pre-commit
Posted by GitBox <gi...@apache.org>.
liuxiran commented on pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957#issuecomment-880368716
> we can add this in later PR, is that cool for you
👏 so cool ~, that's a deal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1957: feat: added husky for pre-commit
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957#issuecomment-869025138
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1957](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (63af84c) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/1e55aa3d531e6cbe5ca90c1dd0d2bfc56bfe1506?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1e55aa3) will **not change** coverage.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1957 +/- ##
=======================================
Coverage 64.01% 64.01%
=======================================
Files 122 122
Lines 3154 3154
Branches 753 753
=======================================
Hits 2019 2019
Misses 1135 1135
```
| Flag | Coverage Δ | |
|---|---|---|
| frontend-e2e-test | `64.01% <66.66%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [web/src/constants.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb25zdGFudHMudHM=) | `100.00% <ø> (ø)` | |
| [web/src/pages/Consumer/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9DcmVhdGUudHN4) | `76.08% <50.00%> (ø)` | |
| [web/src/global.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9nbG9iYWwudHN4) | `36.58% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1e55aa3...63af84c](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1957: feat: added husky for pre-commit
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957#issuecomment-869025138
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1957](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (56d1e1d) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/e3debe5d314010efa7704c7538e3ae7b2025d28e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e3debe5) will **decrease** coverage by `2.89%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1957 +/- ##
==========================================
- Coverage 66.91% 64.01% -2.90%
==========================================
Files 179 122 -57
Lines 6537 3154 -3383
Branches 753 753
==========================================
- Hits 4374 2019 -2355
+ Misses 1897 1135 -762
+ Partials 266 0 -266
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test | `?` | |
| backend-e2e-test-ginkgo | `?` | |
| backend-unit-test | `?` | |
| frontend-e2e-test | `64.01% <66.66%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [web/src/constants.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb25zdGFudHMudHM=) | `100.00% <ø> (ø)` | |
| [web/src/pages/Consumer/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9DcmVhdGUudHN4) | `76.08% <50.00%> (ø)` | |
| [web/src/global.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9nbG9iYWwudHN4) | `36.58% <100.00%> (ø)` | |
| [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | | |
| [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | | |
| [api/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL21haW4uZ28=) | | |
| [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | | |
| [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | | |
| [api/internal/utils/pid.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3BpZC5nbw==) | | |
| [api/internal/handler/migrate/migrate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbWlncmF0ZS9taWdyYXRlLmdv) | | |
| ... and [50 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1957/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e3debe5...56d1e1d](https://codecov.io/gh/apache/apisix-dashboard/pull/1957?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org