You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by zjffdu <gi...@git.apache.org> on 2018/03/16 08:09:15 UTC

[GitHub] zeppelin pull request #2875: ZEPPELIN-3343. Interpreter Hook is broken

GitHub user zjffdu opened a pull request:

    https://github.com/apache/zeppelin/pull/2875

    ZEPPELIN-3343. Interpreter Hook is broken

    ### What is this PR for?
    Currently the interpreter hook mechanism is broken. This PR fix this issue and also add unit test for interpreter hook, (including global hook and note level hook)
    
    
    ### What type of PR is it?
    [Bug Fix | Improvement | Refactoring]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-3343
    
    ### How should this be tested?
    * CI pass
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3343

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2875.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2875
    
----
commit 9b8b21d47e90da9fab23d54cb8cb2e72dca861e9
Author: Jeff Zhang <zj...@...>
Date:   2018-03-16T08:05:31Z

    ZEPPELIN-3343. Interpreter Hook is broken

----


---

[GitHub] zeppelin issue #2875: ZEPPELIN-3343. Interpreter Hook is broken

Posted by felixcheung <gi...@git.apache.org>.

Github user felixcheung commented on the issue:

    https://github.com/apache/zeppelin/pull/2875
  
    hey @zjffdu thanks for making all these improvements, could we make sure there is at least one review before merging?
    @Leemoonsoo 


---

[GitHub] zeppelin pull request #2875: ZEPPELIN-3343. Interpreter Hook is broken

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2875


---